From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by sourceware.org (Postfix) with ESMTPS id 581FE382EF14 for ; Tue, 10 Jan 2023 14:40:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 581FE382EF14 Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ochir/ZX2ptk8U9Hl6O4G7mNBRAPUBA9m+ZpGoqVzhfBKZX3zaa4TvTsMS2gHgmwX0dkVqq6VN/DdZPY12oUXyklWoHoo0YWxUUTiZevHhFUx0E/zSNw1AIllRz+KfvckeKhdpgnW+F7l07DMBkvHf1xw0GtzSN5yXs48/vqipGiS5229poEDu/ZqN1Er7BHmXbu5jo8MRdZHv0f9iKTRomneYGndEdpOpUbxsejDcxYogdvCY4+bvBPbeGg+GWiSXjIHWa1irigkydXYJIQ+uurYcRoCQ8C2Yq04YxRr/doAMe3SxXj8hD9mLNQh9oORjYR05WsVvS/KHuzDlPong== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=esepEDtmfXNujIwFLXM0WSQNnSFEpAyNnpGxa9T6cSk=; b=Uaom0iU2mC/qr/B/1n/geLuDlIu+ymPuTcxDSMIZFu04bxEgpRdS5esCZ5Kn3+GBWNrgaPsDllAPFnXb20GZM9EdoJBpvtJRca2pQzpbRQzIXl+8d9AnwYdV1IbMMSV3aEnIvhp4KSLrDEErrT96Ubuwfvs7p049LOhQPX7VdLL6BieEHJV2y/+mFCSLOmVenAz59PUcbrMZcu2ZQ6Dns8x1mybi3YL+JuzkSvl6SMdxRbeupqMo2SG3nUrlHAFy9xcBnzoEoObM0456eszYQXmskwUVleY+izbj43GygFx0lqSW8inT8ijaUHu2F1ZwWJMD6WwgcYCjHtQWb2LMAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=esepEDtmfXNujIwFLXM0WSQNnSFEpAyNnpGxa9T6cSk=; b=D9V+ekrHeScYFRvH2YHW4QjN+P4z56RfMKsPbn3AMcRrgnvNlDWvpaqGUUigUW2bmdaw1MP98aIJ9aKFG2J5ajDcQMx3gVebpcOKWc6Qx9jkFX7kWe/+RBxXCxZQ7gZ/zoAWz+QANVg1v0cbgRj3NmYDOGm058snrfbrOGzRO7Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) by IA1PR12MB6332.namprd12.prod.outlook.com (2603:10b6:208:3e2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Tue, 10 Jan 2023 14:40:43 +0000 Received: from DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::5fc0:b696:455b:8330]) by DM4PR12MB5745.namprd12.prod.outlook.com ([fe80::5fc0:b696:455b:8330%3]) with mapi id 15.20.5986.018; Tue, 10 Jan 2023 14:40:43 +0000 Message-ID: <0539ed3a-3163-981f-3b82-1ac31fad8b3a@amd.com> Date: Tue, 10 Jan 2023 14:40:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4] gdb/gcore: interrupt all threads before generating the corefile To: Simon Marchi , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20221206141248.2485033-1-lancelot.six@amd.com> <9c70aa6a-2a00-a985-c080-33d086597ee7@simark.ca> Content-Language: en-US From: Lancelot SIX In-Reply-To: <9c70aa6a-2a00-a985-c080-33d086597ee7@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::8) To DM4PR12MB5745.namprd12.prod.outlook.com (2603:10b6:8:5c::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5745:EE_|IA1PR12MB6332:EE_ X-MS-Office365-Filtering-Correlation-Id: dc7733ae-38f8-4a5b-b856-08daf318a6ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +iKuEkb/lug91FfRT3vfcK9sm7WSSXRbF4k29TqMNDSt8Xm7J/Alb62ij2hHqGyXQ+O7wfIfY4o8b88xb6YPsBgvbcLQGrMmx0txNz90mWVUHE0fuyorLi6CLqI2pqo623kMRmLX1qZg347FkFhgPPmCPbNBrBTTlb3VoCtnesS8N/IjfOwtWiAf/Ce338NwXkAhenkRQjKjle+K5+z0PSgd2GzMc5l8wfW0MBVtGoXJ10v7yjyokbB+iiAUO9uKfOrtiN4oU23VcONssDODUy56dbyokskqIpA6SVU/TI7/MT1VVI3EHVvYZQLXVJ53QrFJcQKPWmVKMJsJpmG5XmuY44wS+YTgZUv0MKsQ0cHQT3EsTKo82wBBrsWxbSuN6ZGTaxEroxHC+siEWvdRjt70Cb45iNtVoS76akLtCfBnPYTqvuJja6agpYwbCL94G6HMRTo56TnOp3iRf6OG1lSJaOav+fNEd1fSYNDRC+aH5NXyl5Rt6JATaQo9LJzhlnXy/KZwG3YE0j6HjXQBBxA+Q9fehrDppnBCF2ca/VotSiGWhPZH8fVWSNGaDFPz8HqDGCHumcr/nvwRnlee8lli2+QnEHh7m8eiOWVOkyLy8TU4GyxM3QLWcbq9CFTceNCQv85b5H2wl4g+TEXPPZbxemFew599N57TInq80umZhjKFjpgQ6mHO0H/kXFLHSp+uMHk803BW6nlGHuPJec5z0x/7elRAJ2WW5rBvYLo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5745.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(451199015)(36756003)(186003)(26005)(6666004)(8936002)(31686004)(6512007)(6506007)(2616005)(66946007)(5660300002)(66476007)(66556008)(316002)(4326008)(86362001)(31696002)(38100700002)(478600001)(6486002)(41300700001)(8676002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N05wLzZNd0grV3gvTDhDa0VsRnNia0NsWlVoQnhLT2h1eFpTbmFxZXpIamI3?= =?utf-8?B?YUtneWFNbUo0ZzlrYXhMTXVlZzBwTE9KOEFPS1Y2SjZvbjV6OW44ZUJHMFNa?= =?utf-8?B?V1l3NVZBYUZoaFNsZHdkcnYzUnZHSnhURDJ4WlhlWk12OEZuNXkySE54NW9s?= =?utf-8?B?a0pwRStORDVXN1VXcTIvM2NwZEhzWDNibFMvQzFrNTZJMTRnRi9IZkZuZFMy?= =?utf-8?B?S09OMVc5dTloU0F0UE81OHNQYnBMNGN6ODRCWlBCM0txZ0Q0Qm9xdmoxYk9P?= =?utf-8?B?T3dmenVpRFlYWmYyTkNYWTV2UVowSys3WUFMS0hRQmc4S0xjd3k2N25YZjZK?= =?utf-8?B?UCt6bGc2U0ZGdEp3RlBwK2tJeEVrejRFOWZlc2tGdWthTDB0bHQ5Q1hJRC9v?= =?utf-8?B?dWdCLzNHN0U5WVZ4Z2ZPelRKYlVjbEllMk8rTlZvVTdXL0JyVVp4UzZZMStX?= =?utf-8?B?RjFKSUNtRk03Q2dWdWtsWHlTRHY3WUY5bTRpUGp5eDNtTFRDS0x6aE1EUURH?= =?utf-8?B?S1dZdnYrVlFFYnpkL2IzRy8xL3lqS3lZdC9lQXRmNlJvYkdJaWZoSnZ4Q2xz?= =?utf-8?B?NVRDZUJqbGNKT21qaEozWEpPOFZIZklyYmJuYWdINmVxOWZBa1Q5d0xxMTlB?= =?utf-8?B?QzFsTHRLWDZScE0zbUFNKzNudzdBdnA4d2U5ZlpMTDYvQ2p3RUtwVG4rSUha?= =?utf-8?B?dnlKNHVQK3d1emlXMDZvNnMrWWZoRm1oMGo4cnJ0aDVUaVBQSnBnb083d3pu?= =?utf-8?B?VEFneFQ4a1lNUys4TWZDcjRVZTFaUWpxdUZnYml6MXFKSlZjVkFuWmhzQVBI?= =?utf-8?B?eEIzMGZ3dWNzRThkMHFMeXRJbWY3RHhTd1NYV2thTHNXREhRSVpteHl0Sm1u?= =?utf-8?B?MjUzV243NG13SDI4UWRqZXVRUSt2by90TloxSUxoRWovYnhZTUNpMThYbE1u?= =?utf-8?B?ZmphY1UvUnRoTE9kN1ZBT3BHVFBSS2o4NjhXTzJPVzJBcTFpcmhJeE1PNmll?= =?utf-8?B?NkJNV0dDdE9ROC9EdTAza3BuTnZtdmpwV2h2MWg0b3lSQmt6cENTZVV1ZnFW?= =?utf-8?B?ZVpBU3FxcHBkVitQNU16ZUE5eHVuZHA1RGc5anlPWGliOVRhdFVUMmJyZjNo?= =?utf-8?B?UEZrSFFqNWpzZ0ZKbFRQR0hnTWNqWTh6UXl3czF2N0FFbUhMQ3lZNkpTNkZD?= =?utf-8?B?QUpMM25TN0Nnb2hscSthVUxUcTUrMmVpMStsa01KWWN2SFN2RVdncllCS0ZN?= =?utf-8?B?S1hGTnRvMmNzMCt5YnJhK2RKTEc4TGNLSXM2OFlUc2RGclB4K09wWjJQWENZ?= =?utf-8?B?SVJKU2RvT2gySEoramIxUnVkb0JuWVpOT2hiWXF1dUZJOXQ0R3NHWjl4RHRB?= =?utf-8?B?OWZlSnhTemNXUng3bXhTbGdpTisybnRpNElpUXd2eGtLVCtTRit3bXNscHBO?= =?utf-8?B?NWxGcS9pVjZTSVZFaTJZOWF4S09iU2NJMmlzZXQveHRncFA0SU16cVlaMVgx?= =?utf-8?B?Q2JWUHNOcW8yS216S3U4V24yWFcxZlFOZVlJdVpwTmM2WW1BYjIyS3UzQlVQ?= =?utf-8?B?ZGc5SExkZTk4czNqeG1ya1V4ZG9IVVErVFRGeVdlVGtOQVpWOS9peGVseXAr?= =?utf-8?B?dkpubTVKaUpRaFd2enBWODFhbjQ0OVZWUnFpcTJYSE9qNzZLUXpkSUo0djNT?= =?utf-8?B?cVZQcDR4QzdYZTljMWVMdWVDcG90RlBkQ3ZqSHVSUlVlQTN0OGI3MzBabU1N?= =?utf-8?B?VFBYbXZvVHFzZ0UxdEYvME1ONHJFb0lxME5UZmlHSHl2RkdvMHFKaGlHYmxt?= =?utf-8?B?YmFNS3loeTFkTTJWWmR2MHA0MmR6UkFwalFVZ2tMVEpIbmMwTTZLSVZVUVBE?= =?utf-8?B?MTJrRjdrMWd4RzBVWGdCK1FOQzlULzVNcHpvSkpJdlllQUh1QUNtTWh3eWJu?= =?utf-8?B?TGZ4SkVVb2RncVZlMEpxV2VMR0dLZ0swQUp3amRKWTYrK3JudTNYWGlVNUo5?= =?utf-8?B?M0NpcTJPbDVqNVF1RkN5cUVlbFMwSGN2THovcXpmS3I0Y2p3MFN1SkR0RkRm?= =?utf-8?B?dG9PZTlEdGVQelh3VmlDVnJ1U0J0T2VRWDYrOUJkV2lOOERyQkd1dlNSQ1Ni?= =?utf-8?Q?83/v7QGbHJUzYwzn9yL4YZ9hd?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc7733ae-38f8-4a5b-b856-08daf318a6ee X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5745.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2023 14:40:43.4741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kz+fdubH1eMCnU/QjN4ln1hthy2/mOg60Vyns7ooysmRs8XI+T6g9PSNayBQNb6ORPzJ1gEse50t8GMuigsqCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6332 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Thanks for the review! >> + bool all_stop_was_running = false; >> + if (exists_non_stop_target ()) >> + stop_all_threads ("generating coredump", inf); >> + else >> + { >> + all_stop_was_running = any_thread_of_inferior (inf)->executing (); > I'm wondering what happens if you call this while the inferior is doing > an in-line step over, with one thread resumed and the others stopped. I > think the others will have executing == false, so could you fall on one > that isn't executing? I am not entirely sure about those cases, but you might be right. I could explicitly check all threads: for (thread_info *t : all_non_exited_threads (inf->process_target (), ptid_t (inf->pid)) all_stop_was_running |= t->executing (); I'll do that in next revision. >> + >> +# This testcase checks that when in non-stop mode with some threads running >> +# the gcore command can interrupt all threads, generate a core dump and >> +# restart threads as required. >> + > > Please add a short comment explaining the goal of this test. > There is one just above, but I recon it can be improved. >> +standard_testfile >> + >> +if { [prepare_for_testing "failed to prepare" \ >> + ${testfile} ${srcfile} {pthreads debug}] } { >> + return >> +} > > prepare_for_testing starts GDB, but it gets restarted below anyway. Use > build_executable to avoid the unnecessary spawn. > I will do that for next revision. >> + >> +save_vars { GDBFLAGS } { >> + append GDBFLAGS " -ex \"set non-stop on\"" >> + clean_restart ${binfile} >> +} >> + >> +set lineno [gdb_get_line_number "Break here"] >> +if { ![runto $lineno] } { >> + return >> +} >> + >> +# We should be stopped in thread 1 while thread 2 is running. >> +gdb_test_sequence "info threads" "info threads" { >> + {Id\s+Target Id\s+Frame} >> + {\*\s+1[^\n]*\n} >> + {\s+2\s+[^\n]*\(running\)[^\n]*\n} >> +} >> + >> +set th1_pc "" >> +gdb_test_multiple "p/x \$pc" "fetch thread 1 PC" { >> + -wrap -re "$::decimal = ($::hex)" { >> + set th1_pc $expect_out(1,string) >> + pass $gdb_test_name >> + } > > Could that use get_hexadecimal_valueof? > Probably yes. I will use this also. > Simon > Thanks, Lancelot.