From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 479393857C4A; Wed, 6 Mar 2024 17:22:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 479393857C4A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 479393857C4A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709745724; cv=none; b=FpMIDEhrJg2KCtrcOR91K3wTaaMkfbu4NRhWgoUiCyI6F0kzbR6cwLC4EgrinJgaU9r00OZ3vTZDAJuFZfYRxbrUNF4mJxoZ8SMFu9oJGI48pSdQemPjkE06WQCCDmnGh053dkLFZLQbbXIyEUnRA5eA99qgkL8Gph/Sk4WKGfc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709745724; c=relaxed/simple; bh=xhrjU0e76XM5UyB/D1vMHgDAiE9R9d9GiOMCTjad3Gk=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=khCXC9l68spDaSny9N6ZY6pyG86LjkrvcmbAQx3Up4EhMVTOJcdoHGahZrUDNyB52VC+/GvPySNajauwyEn+t+zm4aRmV+BnW1RKx0O0gr8ENaBXoWnpe1erXqMJN/eZ7Yjrwdxg9AhgJYJv2nAB6HnaCv9+T/3YpGbKMOaYwCk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1C73DC15; Wed, 6 Mar 2024 09:22:40 -0800 (PST) Received: from [10.2.78.54] (e120077-lin.cambridge.arm.com [10.2.78.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A20673F738; Wed, 6 Mar 2024 09:22:01 -0800 (PST) Message-ID: <0552c766-4480-4482-b86c-df3a4d8c64e2@arm.com> Date: Wed, 6 Mar 2024 17:22:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Help needed with maintainer-mode Content-Language: en-GB To: Andrew Carlotti , Christophe Lyon Cc: Mark Wielaard , binutils@sourceware.org, GCC Mailing List , gdb-patches@sourceware.org References: <20240229110039.GB18580@gnu.wildebeest.org> <70455fee-b67a-2f85-b93e-76c735564796@e124511.cambridge.arm.com> From: "Richard Earnshaw (lists)" In-Reply-To: <70455fee-b67a-2f85-b93e-76c735564796@e124511.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3491.5 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/03/2024 15:04, Andrew Carlotti via Gcc wrote: > On Thu, Feb 29, 2024 at 06:39:54PM +0100, Christophe Lyon via Gcc wrote: >> On Thu, 29 Feb 2024 at 12:00, Mark Wielaard wrote: >>> >>> Hi Christophe, >>> >>> On Thu, Feb 29, 2024 at 11:22:33AM +0100, Christophe Lyon via Gcc wrote: >>>> I've noticed that sourceware's buildbot has a small script >>>> "autoregen.py" which does not use the project's build system, but >>>> rather calls aclocal/autoheader/automake/autoconf in an ad-hoc way. >>>> Should we replicate that? >>> >>> That python script works across gcc/binutils/gdb: >>> https://sourceware.org/cgit/builder/tree/builder/containers/autoregen.py >>> >>> It is installed into a container file that has the exact autoconf and >>> automake version needed to regenerate the autotool files: >>> https://sourceware.org/cgit/builder/tree/builder/containers/Containerfile-autotools >>> >>> And it was indeed done this way because that way the files are >>> regenerated in a reproducible way. Which wasn't the case when using --enable-maintainer-mode (and autoreconfig also doesn't work). >> >> I see. So it is possibly incomplete, in the sense that it may lack >> some of the steps that maintainer-mode would perform? >> For instance, gas for aarch64 has some *opcodes*.c files that need >> regenerating before committing. The regeneration step is enabled in >> maintainer-mode, so I guess the autoregen bots on Sourceware would >> miss a problem with these files? >> >> Thanks, >> >> Christophe > > Speaking of opcodes/aarch64-{asm|dis|opc}-2.c - why are these in the source > directory in the first place? For a similar situation in GCC (gimple-match, > generic-match, insn-emit, etc.) we write the generated files to the build > directory, and generation is always enabled. I see no reason not to do the > same thing for aarch64-{asm|dis|opc}-2.c. > GCC supports building a canadian cross, but binutils doesn't. To put them in the build area would require setting up host compiler as well and I don't think there's currently enough appetite for doing that extra work. But every do has its day; maybe the time has come... R. > Andrew > >>> >>> It is run on all commits and warns if it detects a change in the >>> (checked in) generated files. >>> https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen >>> https://builder.sourceware.org/buildbot/#/builders/binutils-gdb-autoregen >>> >>> Cheers, >>> >>> Mark