From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id EBB9A3858D1E for ; Thu, 19 Oct 2023 14:52:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBB9A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBB9A3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697727153; cv=none; b=T0oTx89TkxofJu1wrowp4Cf+nlGOMNxlqL5F2g7yJ2jKt/3sJNDaudSemzMzoiPBLV2QHdi3xr/aGVPf0T7QNngG72W3vfupXb680Dl84J0I0cT6EsFEY4MYFNl5YhTDnELCnY5Fs84qcVqPEPaEA8FpawR48tmOw/K64iZMPRA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697727153; c=relaxed/simple; bh=syj/+P1id7RySgD1MgJ4zjWp6gr9JG7J6rfT1oW+nhE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=S96YdXRayQmc4iCxcDj+6y7eXy5l9K75FkLAkCbpxpbHw9at2xxVjEUFIECAFN4+3JRag79m1O7iWACEzeDlPd6aBLrnqF5w84NlKge/ezxwNKsfz/Dmj9T5zA+FKjtyX0BEuJySvEOjZL7CCWR0PvyF4nqWteRSbpNTVLDawcA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1697727151; bh=syj/+P1id7RySgD1MgJ4zjWp6gr9JG7J6rfT1oW+nhE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=py2l9qsm6HmE3WfGbadtWzx4OOy/bjLY8hvxwBrM1h7eumKftuOtPwoL9lXnbNjXw DeHTMqocew6B3q87lYvwXoYYWWvt+xG4XBjmhcBaprc2s2WpwMUL1JixE+gJ5SWUpA 9cslQYKXLPT1ydvJ2cvxyRFH7RMqSgkhzSHRt6SQ= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1923C1E00F; Thu, 19 Oct 2023 10:52:31 -0400 (EDT) Message-ID: <0569999c-5973-41e1-93c3-91f8087de17e@simark.ca> Date: Thu, 19 Oct 2023 10:52:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 16/24] gdb: make clear_so a method of struct so_list Content-Language: fr To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-17-simon.marchi@efficios.com> <20231019110824.vjuiao3wddrewpv6@khazad-dum> From: Simon Marchi In-Reply-To: <20231019110824.vjuiao3wddrewpv6@khazad-dum> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/19/23 07:08, Lancelot SIX wrote: > Hi Simon, > > On Tue, Oct 10, 2023 at 04:40:11PM -0400, Simon Marchi wrote: >> ... just because it seems to make sense to do so. >> >> Change-Id: Ie283c92d9b90c54e3deee96a43c6a942d8b5910b >> --- >> gdb/solib.c | 35 ++++++++++++++--------------------- >> gdb/solist.h | 10 ++++++++++ >> 2 files changed, 24 insertions(+), 21 deletions(-) >> >> diff --git a/gdb/solib.c b/gdb/solib.c >> index 5ed223b8dfca..8f5b6e02e71c 100644 >> --- a/gdb/solib.c >> +++ b/gdb/solib.c >> @@ -623,39 +623,32 @@ solib_map_sections (so_list &so) >> return 1; >> } >> >> -/* Free symbol-file related contents of SO and reset for possible reloading >> - of SO. If we have opened a BFD for SO, close it. If we have placed SO's >> - sections in some target's section table, the caller is responsible for >> - removing them. >> +/* See solist.h. */ >> >> - This function doesn't mess with objfiles at all. If there is an >> - objfile associated with SO that needs to be removed, the caller is >> - responsible for taking care of that. */ >> - >> -static void >> -clear_so (so_list &so) >> +void >> +so_list::clear () >> { >> const target_so_ops *ops = gdbarch_so_ops (current_inferior ()->arch ()); >> >> - delete so.sections; >> - so.sections = NULL; >> + delete this->sections; >> + this->sections = NULL; > > That's just a nit, but while at touching those lines, the NULL could be > changed to nullptr. Done. Simon