From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) by sourceware.org (Postfix) with ESMTPS id F12BA386F41D for ; Mon, 25 May 2020 19:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F12BA386F41D Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id C2B572C500E; Mon, 25 May 2020 15:56:07 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vXORZkW6WIPu; Mon, 25 May 2020 15:56:07 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 94D8A2C500B; Mon, 25 May 2020 15:56:07 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 94D8A2C500B X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wA2V9QmVqgbB; Mon, 25 May 2020 15:56:07 -0400 (EDT) Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) by mail.efficios.com (Postfix) with ESMTPSA id 7B5F92C4CE5; Mon, 25 May 2020 15:56:07 -0400 (EDT) Subject: Re: [PATCH v2 00/42] Share DWARF partial symtabs between objfiles To: Pedro Alves , Tom Tromey , Simon Marchi via Gdb-patches References: <20200512210913.5593-1-simon.marchi@efficios.com> <875zcn1xwp.fsf@tromey.com> <5032927f-877b-100b-c3a7-55c78d3a7d7a@redhat.com> From: Simon Marchi Message-ID: <058f6a56-4690-cfd8-ede4-a9bbafc85e1a@efficios.com> Date: Mon, 25 May 2020 15:56:07 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <5032927f-877b-100b-c3a7-55c78d3a7d7a@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 19:56:09 -0000 On 2020-05-23 8:24 a.m., Pedro Alves wrote: > On 5/22/20 10:07 PM, Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi via Gdb-patches writes: >> >> Simon> The big difference between v1 and v2 is how the split is done. >> [...] >> >> Thank you so much for doing this. This is a big improvement over the >> approach I took. >> >> I read through the patches. It was difficult to do without glazing over >> a bit, so I'm not sure I really did a good job. However, I'm >> comfortable with the direction you've taken here. > > I skimmed through the patches, glazing over a lot. The direction seems > good to me too, FWIW. > > Just wanted to say, kudos for continuing this effort, and thanks for all > the work. > > Pedro Alves > I posted the complete version of patch 15/42 (it was missing the commit message). Other than that, does any of you have further comments? I've done the small suggested fixups, but I don't think there was anything big requiring another round, is there? Simon