From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id 7172538425BE for ; Tue, 24 May 2022 14:17:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7172538425BE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id y24so2944490wmq.5 for ; Tue, 24 May 2022 07:17:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xerzNH4SBv3W1yIgUFdqQ7hWPbcarUXUa9mZc+xSni4=; b=Dq6PxeJyO/OLkcOXVDJsXdMaqZngRczJ8y4uE0OrINV06nHfaIKX4n5fB0+J4MDE3S l0Fj1Fix2Q5k0ZY1LJOlvPD4+f9VbfVTGgW0RvlCTB8okYRfvKVKZJeRtazsnPBD3Gcm Mwihv5jwcDp1M5VY9VbUBKZY9K4GgTDLFb7csmfFYxNMqWYxtm5C26J91Ydu8YOmZ7UB 9HYzeUfRi9Lyiyp4/5tOVVEZ/xS3m6DxTNdf2lSXT9NkAIeTGLF0AmSaFa1QyN5Lburf dOrohlwaPi2itL2oKMwF+8UcgxWI8mtWriD63bCAJw/9xqh9xuMWn8LU9oqYwOv5AS9i Mg0w== X-Gm-Message-State: AOAM5333xJ2epoUlMtA8HfCCkL8ljRSJwezLzBYoHKYiMbM29jYIPiPr EMb+ltJhpUYU4+i5iFPhP5p7hht6mZY= X-Google-Smtp-Source: ABdhPJyr+G3qVNoDFs4lzRlGg0Qv+PyA/OjaLC83nRkkDCM9DsGfK3Rfk15N+qmtIjJvMh1CdqnJqA== X-Received: by 2002:a05:600c:a06:b0:394:8d3d:de68 with SMTP id z6-20020a05600c0a0600b003948d3dde68mr4160246wmp.18.1653401847292; Tue, 24 May 2022 07:17:27 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id k24-20020a05600c1c9800b003942a244f49sm2528462wms.34.2022.05.24.07.17.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 07:17:26 -0700 (PDT) Message-ID: <05b3833a-9d87-53d2-e0a9-5b481e597929@palves.net> Date: Tue, 24 May 2022 15:17:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 0/2] info breakpoints improvements Content-Language: en-US To: Andreas Schwab , Eli Zaretskii via Gdb-patches References: <20220519215552.3254012-1-pedro@palves.net> <70ddb0b0-7c7d-3bcd-ef3d-246290ae1edf@arm.com> <1e932144-4f4d-4c10-bbaa-deef05684895@palves.net> <83fskz5aol.fsf@gnu.org> <0247c63e-189d-0a71-8b5f-257fd83ff6a3@palves.net> <83czg359mz.fsf@gnu.org> <45d7d87f-f78a-7c6b-28d7-285beecf9a8a@palves.net> <83bkvn58pe.fsf@gnu.org> <87sfozowak.fsf@igel.home> From: Pedro Alves In-Reply-To: <87sfozowak.fsf@igel.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 May 2022 14:17:30 -0000 On 2022-05-24 15:11, Andreas Schwab wrote: > On Mai 24 2022, Eli Zaretskii via Gdb-patches wrote: > >>> Date: Tue, 24 May 2022 14:50:01 +0100 >>> Cc: luis.machado@arm.com, gdb-patches@sourceware.org >>> From: Pedro Alves >>> >>>>> A location only breaks if it is enabled, _and_ its parent is enabled, so never. >>>> >>>> That's what I thought. But then why not "propagate" the "n" of the >>>> disabled breakpoint to all of its locations? >>> >>> Because then when you re-enable the parent breakpoint, you'd have lost the enabled/disabled >>> state of the individual locations. >> >> I don't understand why would that be lost. I'm not proposing to >> actually disable each location, I propose to _display_ them as >> disabled in that case. > > I think it would be better in that case to omit the column or display it > as "-", to indicate that it is ignored right now. > Yes, we could print them differently, preserving the user-specified enable/disable state. We print them in uppercase N/Y when the location is disabled due to an invalid condition already, for example.