From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de (mout.web.de [217.72.192.78]) by sourceware.org (Postfix) with ESMTPS id F255D3858405 for ; Wed, 30 Mar 2022 10:36:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F255D3858405 X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.111.41] ([95.90.135.181]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MKM5t-1nJurg0aVz-00LsyL; Wed, 30 Mar 2022 12:35:35 +0200 Message-ID: <05e800f2-c119-1675-7465-f3ea3168cb58@web.de> Date: Wed, 30 Mar 2022 12:35:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 2/8] GDB/Python: Use None for `var_zuinteger_unlimited' value set to `unlimited' Content-Language: en-US To: "Maciej W. Rozycki" , gdb-patches@sourceware.org Cc: Andrew Burgess , Simon Marchi , Tom Tromey References: From: Simon Sobisch In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:SLuhMsh3wZ1ojnkr1sS59xkhdm6AQzYYEJlPqfOIf6cQqPv2S1S LPyvP3Q3QOdkfrAoznuiiF2xZLZpHyZrxuwRxjNC07hwDd6x4PGaSP6i9u0eYIxb+Wku705 M+eVynEbt1FuOiyxt3zvhPY1WuVHRSmQ48c8X2EPoyQ1P7KO88KP7iIQN9G+9T8yOehKMKR eRx0Gs15Lwwa7ezCI0bmg== X-UI-Out-Filterresults: notjunk:1;V03:K0:BJMgDfP1yJQ=:jzlfH5KZKVnukxySSwoYcI rhVOZuBol3gqkQRLiiL8gnq0bONTI2ct1D7uuwujXIGfx7T8cizzrpKfajMkW51fudLXD1raQ /2ZnV7a50ER7qkxQOeT6SQ45W5gPiBEokoU1VNt10UKdXY2bxGu3WmvrZn7XoD3WCAhDhjgie 8WSUgAxJc3wCrOHph9fUR6fQR/d+i0L+s+Om+kqbC5M60jcfZ4ZyzOXSjD2lGAE0mBZekE/gV YawjYEzNGH9G2IjzQ5/D3q8ZZB0sHTC0PoHO65TFQcR1plYp/efTcr+hXKvsNu19LpSI9wezU NsUqs6wK0NRjkNU/ItG231+PCkk6wstWANYNHhmf2uysl/lavPEHn0d3V1edgHPUJVFNhta9K wCYsKHPVizSeY4ZFfrbbhoywlEphUxdnw1JAu14zH4zbiz7wfSqvubiKGSvxVaYT6aflvMOOC 6qMATqZH13hyVWs0bR8btuHbreIr3/61mXDTHGYVPWq+Rm4vaNmlTleRHbhj0VF5qVA36WQ06 h8KDWQXbO1O6aZ8z1mVRFx3eK16eVRRsH5kcwJRDjo0PxM5Z5BbNMVA28XgO8HhiblXA21gOr t+UZ+jm/jlzOjf9CS/ShMvhEN08pQzZ/cFRpvmJb/LiTG6/bxrFKF4PBOKLcdi6D098KiXwBr aRqb0foEebc93lS5/zONT+//I6dfuaZ3+YNkvhCWBMmaRyguI+VdSDKomISXxjDWqeHR+y3Xy JLlSfjBhQYTMNZ4RwFuMmIWNbSEHtcMx2jOc6Y48Hu7XMiXQwv2ciJpAMg2MVFr14gWcaVet9 yXqZdBvJL66eT7bDV03cLzpGcPyf1wF8zASr1yxF9meLvm5jJg+OrD8SqPW1Bq3VLlkhOK0Eh U9MLAKmNi+olBN92EFVE/Gli+hyGQ+wg/ukYjDmJSZBlpzeiIpeIk+Nc8s1+pPv5tVs3knyYX rNFAzMfvnNevt3YUskEy4n3IeGadkJ+mLl3ZXCndHUKFKC7d1+xGuaX3OCyS9+19kHf0dPs8v STTv+e7JikimXGmBbkU9Rh50SurK18qPjNV2wrl2aRuFuV6bmi0t8tZTGzTzxz0szVZ1a9PhM 6me97sgdy3OLL0= X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_ASCII_DIVIDERS, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 10:36:06 -0000 That seems like it should be mentioned in NEWS as it possibly affects existing python extensions (if the commit that was fixed landed in an official release). Am 30.03.2022 um 12:23 schrieb Maciej W. Rozycki: > Consistently with the `var_integer' and `var_uinteger' parameters return > the special value of None for a `var_zuinteger_unlimited' parameter set > to `unlimited' by using the Py_RETURN_NONE macro in this case, fixing > commit 0489430a0e1a ("Handle var_zuinteger and var_zuinteger_unlimited > from Python"); cf. PR python/20084. Adjust the testsuite accordingly. > --- > No change from v4. > > New change in v4. > --- > gdb/python/python.c | 10 +++++++++- > gdb/testsuite/gdb.python/py-parameter.exp | 4 ++-- > 2 files changed, 11 insertions(+), 3 deletions(-) > > gdb-python-var-zuinteger-unlimited-none.diff > Index: src/gdb/python/python.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- src.orig/gdb/python/python.c > +++ src/gdb/python/python.c > @@ -507,9 +507,17 @@ gdbpy_parameter_value (const setting &va > Py_RETURN_NONE; > /* Fall through. */ > case var_zinteger: > - case var_zuinteger_unlimited: > return gdb_py_object_from_longest (var.get ()).release (); > > + case var_zuinteger_unlimited: > + { > + int val =3D var.get (); > + > + if (val =3D=3D -1) > + Py_RETURN_NONE; > + return gdb_py_object_from_longest (val).release (); > + } > + > case var_uinteger: > { > unsigned int val =3D var.get (); > Index: src/gdb/testsuite/gdb.python/py-parameter.exp > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- src.orig/gdb/testsuite/gdb.python/py-parameter.exp > +++ src/gdb/testsuite/gdb.python/py-parameter.exp > @@ -343,8 +343,8 @@ proc_with_prefix test_integer_parameter > } elseif {$kind =3D=3D "PARAM_ZUINTEGER_UNLIMITED"} { > gdb_test_no_output "python test_param_$kind.value =3D -1" \ > "check that PARAM_ZUINTEGER value can be set to -1" > - gdb_test "python print(gdb.parameter('test-$kind'))" "-1" \ > - "check that PARAM_ZUINTEGER value is -1 after setting" > + gdb_test "python print(gdb.parameter('test-$kind'))" "None" \ > + "check that PARAM_ZUINTEGER value is None after setting" > } else { > error "invalid kind: $kind" > }