From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99262 invoked by alias); 15 Feb 2019 10:49:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99234 invoked by uid 89); 15 Feb 2019 10:49:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-1.6 required=5.0 tests=BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=here=e2, H*c:MHil, H*c:HpplH, HX-Received:b48d?= X-HELO: mail-pl1-f195.google.com Received: from mail-pl1-f195.google.com (HELO mail-pl1-f195.google.com) (209.85.214.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Feb 2019 10:49:45 +0000 Received: by mail-pl1-f195.google.com with SMTP id bj4so4775310plb.7; Fri, 15 Feb 2019 02:49:44 -0800 (PST) Return-Path: Received: from resnet-11-41.resnet.ucsb.edu (ResNet-11-41.resnet.ucsb.edu. [169.231.11.41]) by smtp.gmail.com with ESMTPSA id z62sm12259545pfi.4.2019.02.15.02.49.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 02:49:42 -0800 (PST) From: Saagar Jha Message-Id: <0633315F-7EF9-4A1A-A15E-53BA244FB566@saagarjha.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_E7A711D5-4C1D-4D90-B360-3E642388A50B" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.2\)) Subject: Re: [PATCH] Use new Darwin operating system names Date: Fri, 15 Feb 2019 10:49:00 -0000 In-Reply-To: <4e4b1e4e-57b9-c754-9e49-55c9ad8e1812@redhat.com> Cc: Kevin Buettner , binutils@sourceware.org, gdb-patches@sourceware.org To: Nick Clifton References: <20190214191325.2354ddbc@f29-4.lan> <4e4b1e4e-57b9-c754-9e49-55c9ad8e1812@redhat.com> X-SW-Source: 2019-02/txt/msg00252.txt.bz2 --Apple-Mail=_E7A711D5-4C1D-4D90-B360-3E642388A50B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Content-length: 124 Here=E2=80=99s a new patch with the changes you=E2=80=99ve asked for. Let m= e know if you need anything else! Saagar Jha --Apple-Mail=_E7A711D5-4C1D-4D90-B360-3E642388A50B Content-Disposition: attachment; filename=Use-new-Darwin-operating-system-names.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="Use-new-Darwin-operating-system-names.patch" Content-Transfer-Encoding: quoted-printable Content-length: 2241 >From c1e3bddc43e2d4a7f3178024e57b8d75290a0e1d Mon Sep 17 00:00:00 2001=0A= From: Saagar Jha =0A= Date: Fri, 26 Oct 2018 04:44:28 -0700=0A= Subject: [PATCH] Use new Darwin operating system names=0A= =0A= Replace MacOSX with macOS, IOS with iOS, and WatchOS with watchOS.=0A= =0A= include/ChangeLog:=0A= 2019-02-15 Saagar Jha =0A= =0A= * mach-o/loader.h: Use new OS names in comments.=0A= ---=0A= include/mach-o/loader.h | 6 +++---=0A= 1 file changed, 3 insertions(+), 3 deletions(-)=0A= =0A= diff --git a/include/mach-o/loader.h b/include/mach-o/loader.h=0A= index a870e50ba0..edf0a8becf 100644=0A= --- a/include/mach-o/loader.h=0A= +++ b/include/mach-o/loader.h=0A= @@ -174,8 +174,8 @@ typedef enum bfd_mach_o_load_command_type=0A= BFD_MACH_O_LC_ENCRYPTION_INFO =3D 0x21, /* Encrypted segment info. */= =0A= BFD_MACH_O_LC_DYLD_INFO =3D 0x22, /* Compressed dyld information. */= =0A= BFD_MACH_O_LC_LOAD_UPWARD_DYLIB =3D 0x23, /* Load upward dylib. */=0A= - BFD_MACH_O_LC_VERSION_MIN_MACOSX =3D 0x24, /* Minimal MacOSX version. *= /=0A= - BFD_MACH_O_LC_VERSION_MIN_IPHONEOS =3D 0x25, /* Minimal IOS version. */= =0A= + BFD_MACH_O_LC_VERSION_MIN_MACOSX =3D 0x24, /* Minimal macOS version. */= =0A= + BFD_MACH_O_LC_VERSION_MIN_IPHONEOS =3D 0x25, /* Minimal iOS version. */= =0A= BFD_MACH_O_LC_FUNCTION_STARTS =3D 0x26, /* Compressed table of func st= art. */=0A= BFD_MACH_O_LC_DYLD_ENVIRONMENT =3D 0x27, /* Env variable string for dyl= d. */=0A= BFD_MACH_O_LC_MAIN =3D 0x28, /* Entry point. */=0A= @@ -186,7 +186,7 @@ typedef enum bfd_mach_o_load_command_type=0A= BFD_MACH_O_LC_LINKER_OPTIONS =3D 0x2d, /* Linker options. */=0A= BFD_MACH_O_LC_LINKER_OPTIMIZATION_HINT =3D 0x2e,/* Optimization hints. = */=0A= BFD_MACH_O_LC_VERSION_MIN_TVOS =3D 0x2f, /* Minimal tvOS version. */=0A= - BFD_MACH_O_LC_VERSION_MIN_WATCHOS =3D 0x30, /* Minimal WatchOS version. = */=0A= + BFD_MACH_O_LC_VERSION_MIN_WATCHOS =3D 0x30, /* Minimal watchOS version. = */=0A= BFD_MACH_O_LC_NOTE =3D 0x31, /* Region of arbitrary data. */=0A= BFD_MACH_O_LC_BUILD_VERSION =3D 0x32, /* Generic build version. */=0A= }=0A= --=20=0A= 2.20.1=0A= =0A= --Apple-Mail=_E7A711D5-4C1D-4D90-B360-3E642388A50B Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Content-length: 714 > On Feb 15, 2019, at 02:02, Nick Clifton wrote: > > Hi Saagar, > >> >> 1) This entry should go in include/ChangeLog, so you don't need to >> have the include/ prefix. >> >> 2) Please adjust it to indicate that only the comments are affected. >> Like this, perhaps: >> >> * mach-o/loader.h: Use new OS names in comments. >> >> Otherwise, it looks good to me. >> >> I wish I could tell you to check this in, but I think that the >> binutils maintainers will need to approve this change. I've added >> binutils@sourceware.org to the "To:" header in my reply. > > It is fine with the binutils too. So please apply with the changes > that Kevin has outlined. > > Cheers > Nick > > --Apple-Mail=_E7A711D5-4C1D-4D90-B360-3E642388A50B--