From: Simon Marchi <simon.marchi@polymtl.ca>
To: Gary Benson <gbenson@redhat.com>
Cc: Tom de Vries <tdevries@suse.de>,
gdb-patches@sourceware.org,
Pedro Alves <palves@redhat.com>
Subject: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp
Date: Sat, 13 Oct 2018 22:18:00 -0000 [thread overview]
Message-ID: <06b38d2e3f0a9394280553e70b9dfaf8@polymtl.ca> (raw)
In-Reply-To: <20181011083318.GA13751@blade.nx>
On 2018-10-11 04:33, Gary Benson wrote:
> Tom de Vries wrote:
>> On Wed, Oct 10, 2018 at 02:44:24PM +0100, Gary Benson wrote:
>> > Oh! Ok, so [target_info gdb_protocol] != ""] maybe?
>>
>> Attached patch uses this this.
>>
>> OK for trunk?
>
> Please reorder the checks at the start like this, to minimize the
> work done before bailing:
>
> 1. check gdb_protocol native
> 2. check /bin/ls exists on target
> 3. build_executable
>
> The patch is ok by me with these changes, but please wait for a
> maintainer to give the final approval, I don't have those powers :)
> And thanks for doing the work Tom!
>
> Cheers,
> Gary
Just wondering. Would it make life easier if we fixed PR 23368, which
is the reason we have to do the test in an unnatural way? I don't know
if the fix I proposed here is totally correct:
https://sourceware.org/bugzilla/show_bug.cgi?id=23368#c4
but I think it would be an improvement compared to what we have now. I
ran it through the buildbot and there are no regressions. If you want I
can submit a proper patch for that, and then we can rewrite this test in
a more normal way.
Simon
next prev parent reply other threads:[~2018-10-13 22:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 10:11 Tom de Vries
2018-10-09 13:52 ` Gary Benson
2018-10-09 16:40 ` Tom de Vries
2018-10-10 9:28 ` Gary Benson
2018-10-10 13:29 ` Simon Marchi
2018-10-10 13:44 ` Gary Benson
2018-10-11 7:47 ` Tom de Vries
2018-10-11 8:33 ` Gary Benson
2018-10-13 22:18 ` Simon Marchi [this message]
2018-10-15 19:54 ` Tom de Vries
2018-10-15 22:12 ` Simon Marchi
2018-10-23 21:04 ` Simon Marchi
2018-10-23 21:05 ` Tom de Vries
2018-10-23 22:38 ` Tom de Vries
2018-10-23 23:37 ` Simon Marchi
2018-10-24 11:47 ` Tom de Vries
2018-10-24 12:09 ` [PATCH][gdb/testsuite] Log wait status on process no longer exists error Tom de Vries
2018-10-24 14:05 ` Simon Marchi
2018-12-05 19:35 ` Pedro Franco de Carvalho
2018-10-15 22:12 ` [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp Simon Marchi
2018-10-16 16:11 ` Tom de Vries
2018-10-16 17:07 ` Tom de Vries
2018-10-16 20:12 ` Simon Marchi
2018-10-17 7:30 ` Upper case test names Tom de Vries
2018-10-17 12:07 ` Simon Marchi
2018-10-18 12:56 ` Tom de Vries
2018-10-18 13:05 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06b38d2e3f0a9394280553e70b9dfaf8@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).