From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118851 invoked by alias); 13 Oct 2018 22:18:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118834 invoked by uid 89); 13 Oct 2018 22:18:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=oh, Attached, H*f:sk:cda0a9c, Vries X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 13 Oct 2018 22:18:15 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w9DMI8Y1015702 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 13 Oct 2018 18:18:13 -0400 Received: by simark.ca (Postfix, from userid 112) id 89E991EA6D; Sat, 13 Oct 2018 18:18:08 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id D4B1B1E4C2; Sat, 13 Oct 2018 18:18:07 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 13 Oct 2018 22:18:00 -0000 From: Simon Marchi To: Gary Benson Cc: Tom de Vries , gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp In-Reply-To: <20181011083318.GA13751@blade.nx> References: <20181005101122.GA23867@delia> <20181009135155.GB12668@blade.nx> <8f8ffb94-5a0c-8b2b-d541-eaacd7d1f42c@suse.de> <20181010092735.GA29557@blade.nx> <20181010134423.GA23926@blade.nx> <20181011074744.GA7677@delia> <20181011083318.GA13751@blade.nx> Message-ID: <06b38d2e3f0a9394280553e70b9dfaf8@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00314.txt.bz2 On 2018-10-11 04:33, Gary Benson wrote: > Tom de Vries wrote: >> On Wed, Oct 10, 2018 at 02:44:24PM +0100, Gary Benson wrote: >> > Oh! Ok, so [target_info gdb_protocol] != ""] maybe? >> >> Attached patch uses this this. >> >> OK for trunk? > > Please reorder the checks at the start like this, to minimize the > work done before bailing: > > 1. check gdb_protocol native > 2. check /bin/ls exists on target > 3. build_executable > > The patch is ok by me with these changes, but please wait for a > maintainer to give the final approval, I don't have those powers :) > And thanks for doing the work Tom! > > Cheers, > Gary Just wondering. Would it make life easier if we fixed PR 23368, which is the reason we have to do the test in an unnatural way? I don't know if the fix I proposed here is totally correct: https://sourceware.org/bugzilla/show_bug.cgi?id=23368#c4 but I think it would be an improvement compared to what we have now. I ran it through the buildbot and there are no regressions. If you want I can submit a proper patch for that, and then we can rewrite this test in a more normal way. Simon