From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67756 invoked by alias); 4 May 2018 18:34:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67721 invoked by uid 89); 4 May 2018 18:34:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=stood, Hx-languages-length:674, 2018-04-21, 20180421 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 18:34:34 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31608406C7BE; Fri, 4 May 2018 18:34:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id AF6037C3E; Fri, 4 May 2018 18:34:32 +0000 (UTC) Subject: Re: [RFA 9/9] Add -Wimplicit-fallthrough To: Tom Tromey , gdb-patches@sourceware.org References: <20180421183056.29292-1-tom@tromey.com> <20180421183056.29292-10-tom@tromey.com> From: Pedro Alves Message-ID: <06cfb165-df62-7541-9e12-d5226f07078f@redhat.com> Date: Fri, 04 May 2018 18:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180421183056.29292-10-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00126.txt.bz2 On 04/21/2018 07:30 PM, Tom Tromey wrote: > This adds -Wimplicit-fallthrough to the set of default warnings. > > ../ChangeLog > 2018-04-21 Tom Tromey > > * configure: Rebuild. > * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough. > > ChangeLog > 2018-04-21 Tom Tromey > > * configure: Rebuild. Did you change your script to generate the ChangeLog's? The paths in "../ChangeLog" and "ChangeLog" above look like relative to gdb/gdbserver/, while I'd expect to see gdb/ChangeLog and gdb/gdbserver/ChangeLog instead. (Same throughout the series, but this one stood out.) Thanks, Pedro Alves