From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) by sourceware.org (Postfix) with ESMTPS id 8175B3856252 for ; Thu, 5 May 2022 09:31:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8175B3856252 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WnPCUVrzzaYR2oNVc45QMqIVYp4DKt2D4lT7iTIqdgmqV2x6UiibzAZW+V7rJJiVYXorbNuFaz+abyZJp7r19QxnoN+Glv2zj/LdKGKEx+Fe0l70uGYa1+lPOUYggHt5LoENV6lpBcvhlRD+LBDoPUKzeKNx8AJ5+2f5Sh0TOAOewKKGKEFUtG0Zq2ul3xXmfOP2yMRLg7dyFBL1FNs13Tdwg1keFEydpnPhvDuPOlBzYUgWAOcq5ICcR+3ZujIEhXuOa1kQd71pxFv3d++edZGAsYkQfaOi32E7K8uPfaRbipUsGUzQMFVE3kK7cjvFmX3EdTGA2uH3+3s1ASmcGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKa8t5Yej89+EPYhCaM8ctFEySxBPTpZgRk4vn399Uk=; b=aevo6FyHlgy9ckdrENoXdEZSzjzi0F1CSECXvJ6TI11Avvn6HcoeIQTxGs9IIHhGMVjHXS3t+/uPG/CE09CB8sQMAombimVECIepK2m3KsMJfhk1ZAfn2BWfmNLquFob6BmEJEutoAiNXo1Vhex5ErU3ltWu+Afz8t73mLoyaQmOHdfG8g4V7ftTOFzFIH1ZPykcU+pQnd5wPg+9oN2RWJ2AqSaAMWYAEVDwPLiXE+tMt9t1vqy+f9+XHprAFeZDWDVruPcUu1NP10vBXXGpfIT+cvPigVpWGleOdObbKhI1tmR0aob3bDlNK+Ki+6SmGhWEDStFcNm+OvLNk/fqOg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB8PR06CA0052.eurprd06.prod.outlook.com (2603:10a6:10:120::26) by PR3PR08MB5578.eurprd08.prod.outlook.com (2603:10a6:102:83::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 09:31:21 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::2a) by DB8PR06CA0052.outlook.office365.com (2603:10a6:10:120::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.14 via Frontend Transport; Thu, 5 May 2022 09:31:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Thu, 5 May 2022 09:31:20 +0000 Received: ("Tessian outbound 2d401af10eb3:v118"); Thu, 05 May 2022 09:31:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1b49350f205ad809 X-CR-MTA-TID: 64aa7808 Received: from 35b42ac15a10.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0395F92C-7FE2-4D2F-A112-C6B43D6F0CE4.1; Thu, 05 May 2022 09:31:14 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35b42ac15a10.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 05 May 2022 09:31:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJY0y2kiVwRYMDAQKZGQeyfoNwQPiEe/xdVh8sPUQosHJ27lXSUNzB/XVF2ZnIuSHnw6v3/1TRQ8xKID5KUlgggoN5FpT2hZLP8OfkFJT6dQR1vxd+tlUux9f94apP4P0TrNQ7EDGT2myKAa0M4VTQ1ZFNo91A4NL9tu/PdkFGcKKLRjnTQOdElwGdGJQiwySqxsy748AeUe3cSZem1ALfk9p4R1x6E0wB0JIZCoJvjFB6sM7Y7rs4l2Hn8XuJzjetSOc+T7sgKtobWlbrEAN0zagW+/8sXuLIFXNKKmMrAPytDiQjus22UKFtllyS68adUxNt/lve00OjtjvX05uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QKa8t5Yej89+EPYhCaM8ctFEySxBPTpZgRk4vn399Uk=; b=RQb4vRENd8Bmpdov9BiK8nMjqqj1iiGBjhgvPUYRY9GdRMoJ85fF2CX6+74/lBdOoqW5HBTtC2+rc/sNG1GameAXKf1qt9YB23TxvhmxvTXV7+DEKvC1Or9lYYMKqFKVhFWc2hHPB/O4fY5QZjqGwzfEMzeJtM/OOAkoorqjprYZVQhpGC8ZIcduXVwxU9eSAYdKz/+LE4+3i2R42wX01KlN4jLHs20WrQQWid/fEmolkhV/sNdLoR0obTu0jURU79ix4mehQD/hfMKBPGjLyQZVF2NNUCMV0emox8mMN11gD+nMv1XalGiTN8SmdkBE3dKD1bwcE4XYo3KffIrMcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM6PR08MB4167.eurprd08.prod.outlook.com (2603:10a6:20b:ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Thu, 5 May 2022 09:31:12 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5206.025; Thu, 5 May 2022 09:31:11 +0000 Message-ID: <06f43b22-c740-860b-1c75-9a00dcff12da@arm.com> Date: Thu, 5 May 2022 10:31:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Fix crash with "maintenance print arc" Content-Language: en-US To: Tom Tromey , Luis Machado via Gdb-patches References: <20220427100753.364631-1-luis.machado@arm.com> <87h76dmdp9.fsf@tromey.com> From: Luis Machado In-Reply-To: <87h76dmdp9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0323.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::23) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 3068f5fb-5367-47c6-8021-08da2e7a03bc X-MS-TrafficTypeDiagnostic: AM6PR08MB4167:EE_|DBAEUR03FT050:EE_|PR3PR08MB5578:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eCbmdpWLWHnNlHGkIJAKDICHsh9ZipgOFA4NaVJgO7si41Qe+TxKDB43bTOptJV9qNGH4fnwTuqfCT803x07wXZbnQrAe2rwWNlXSHY+OiViwikDDoA4HZLKLu480kS5fNPKWGVjIeOEOnHi3iXPnU5xc/gpDrkb3SO8qpRyCGJyrkH7H7hVuz8651Dhk4S5re5uX8iEf7supIWk3/vvsxrWNbYtxtEimFRiA7O7tztjIboEP+mUWd/HIEFzQ6Gcymm3gUZkyPZRfTpIhxJh6ZgB2iyxJLopW854Xz+mfLlqOrSsQ/tUKi7SFJpFlz6VVWmsva0sIto0hhlpdeXsmINzYl+hQ82b1BIkW4GtmdVzaS6RuLSWmJA1wmovh/KeTIj1WgiEiaF3EkAHxURVrYgSueaU9xIbV+2wl295Ke4H0M717xMKOL9l0dfs89wFobc8SFZoNmCK1t9ueLCqoSBxK5xBLw+PIVYKX5pv5p1fzXyAKmWQavsbc3D02AEpxI5d2RpFMAicJx4SblhhReG1mXiOaeAfT8kealVALvWUBTG9MlOsdZifyNQPGMInpvmTcjhpFVD6eps3qbBjB015RJKgq6iq2JQixBzKy5S2muPXQhkRvSWqEB013qLg5Yif8betbdl+FnIrzq9vAO1w1WUIMOwArNYzmwKvIwFgHUbTFW4/NS5MNqrLDdmwKyojij5xXYRKiNE+HCRRm0fYO58H1rvtbALP/8p/Zzo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(508600001)(26005)(316002)(110136005)(6486002)(2906002)(6512007)(44832011)(8676002)(36756003)(66946007)(66556008)(66476007)(8936002)(5660300002)(31696002)(38100700002)(186003)(31686004)(2616005)(83380400001)(53546011)(86362001)(6506007)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4167 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7429df52-0727-42ff-ca84-08da2e79fdb1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nqLnBZ6o3e9Z3gsAie3yrR70QLTRLtCXpNFcCL8zxUIGKMT6BSkdVLS/pRprdDny6RoqmE4q49cOwhE6OaX1sDBgXq+lkl7NjZcHkhSzvwY/66jGuxSSPrXPmt9vTsGY7S9Xls5ljfGQ4+8HUcwHm16e4ijfvGwSjB8la5d8ZBWRv/HI6nv7P7+rc6dPUYWxQYAILeiJTqZP0e5dU9XLbHfY0rQaEdS49/ODS1Hy0UTHeROtA9TLYcEZDN5Z9uF9aHGfzUkFaWRK+UqTfO0C/oIh84njy8rTdeyI+cQTLN75phwTxYNS5RGrDYuSzmBj5s592biQPua0ddF9LKzx1qYbd/ZgFqs94a1zG02ihd2zNxm/d8e2TFIGQpjeThGxIzvg1Lumg9+DyHBT+0fXmNwOXQxBhGmB/YcHCgdtXZEulZkXaLMdjaTTcmjAm4EXxiAXLjLisXgr0jgHROVjONMaJVIor1UZclImzNQF2cUZ+FVpwDh44i/7SaCZ7rRFu12Hz6jVEewtrikJsfBzQ4p9UJ+LsDmXl81AA87A8/+aLMqXAXmgatAZNqfb6sCla1zUPf6+dpZ/orPJHbYk9A6Z/ZggEvlQ/1Tx3p+P6ugWojfdz6muD7WNY9QZJJ+J2XtNhtS1fQNpXskfmKS9ofgHR3WIOTK62a09xRmRmjfCBj0lD6OgFk91G8WS1UXgYst+U2Y1N9xplJnjx/At7A== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(83380400001)(31696002)(82310400005)(356005)(2616005)(70586007)(8676002)(70206006)(40460700003)(81166007)(36756003)(336012)(47076005)(8936002)(186003)(316002)(2906002)(6486002)(5660300002)(53546011)(508600001)(6512007)(44832011)(31686004)(26005)(6506007)(110136005)(36860700001)(86362001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2022 09:31:20.9763 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3068f5fb-5367-47c6-8021-08da2e7a03bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5578 X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 09:31:25 -0000 Hi Tom, On 4/28/22 16:26, Tom Tromey wrote: >>>>>> "Luis" == Luis Machado via Gdb-patches writes: > > Luis> While doing something else, I noticed GDB crashed with > Luis> "maintenance print arc". > > I think the bug here is that this uses add_show_prefix_cmd and not > add_basic_prefix_cmd. See the appended, which also fixes the crash. > > Luis> This happens because the code expects to find a "show" string pattern > Luis> within "maintenance print arc", since "arc" here is a prefix, and skip it. > Luis> In this case though, it won't find it, and we will have a bad pointer > Luis> getting dereferenced. > > This looks reasonable to me. > > Tom > > diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c > index 98bd1c4bc0a..3edfd466f3b 100644 > --- a/gdb/arc-tdep.c > +++ b/gdb/arc-tdep.c > @@ -2474,11 +2474,11 @@ _initialize_arc_tdep () > /* Register ARC-specific commands with gdb. */ > > /* Add root prefix command for "maintenance print arc" commands. */ > - add_show_prefix_cmd ("arc", class_maintenance, > - _("ARC-specific maintenance commands for printing GDB " > - "internal state."), > - &maintenance_print_arc_list, > - 0, &maintenanceprintlist); > + add_basic_prefix_cmd ("arc", class_maintenance, > + _("ARC-specific maintenance commands for printing GDB " > + "internal state."), > + &maintenance_print_arc_list, > + 0, &maintenanceprintlist); > > add_cmd ("arc-instruction", class_maintenance, > dump_arc_instruction_command, FTR, I'm happy to go with your patch for this one.