From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121846 invoked by alias); 21 Sep 2016 18:30:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 121354 invoked by uid 89); 21 Sep 2016 18:30:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:e400, H*r:111, H*r:2a01 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Sep 2016 18:30:16 +0000 Received: from ESESSHC020.ericsson.se (Unknown_Domain [153.88.183.78]) by (Symantec Mail Security) with SMTP id 00.2C.03250.FA1D2E75; Wed, 21 Sep 2016 20:30:08 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.78) with Microsoft SMTP Server (TLS) id 14.3.301.0; Wed, 21 Sep 2016 20:30:05 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.110.144] (192.75.88.130) by AM3PR07MB385.eurprd07.prod.outlook.com (2a01:111:e400:8820::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.629.8; Wed, 21 Sep 2016 18:30:04 +0000 Subject: Re: [PATCH master+7.12 v2 3/3] Add test for user context selection sync To: Pedro Alves , Simon Marchi References: <20160914174548.5873-1-simon.marchi@ericsson.com> <20160914174548.5873-4-simon.marchi@ericsson.com> <3b2d8c6c3f8cfb4c008162e6f1bad226@simark.ca> <3daec8aa-b88a-e0a1-fe63-4574ef09fbbe@redhat.com> CC: , Antoine Tremblay From: Simon Marchi Message-ID: <07334014-b585-22cd-a555-671f3a89ec4c@ericsson.com> Date: Wed, 21 Sep 2016 21:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <3daec8aa-b88a-e0a1-fe63-4574ef09fbbe@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN2PR80CA034.lamprd80.prod.outlook.com (2a01:111:e400:340b::44) To AM3PR07MB385.eurprd07.prod.outlook.com (2a01:111:e400:8820::11) X-MS-Office365-Filtering-Correlation-Id: eff327cb-3772-40b1-0a01-08d3e24d4f33 X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB385;2:w/PLjzrjBGMJC4+D2tNHaiTaj6vgiN6hRNgCmxm/3dc3cJXh4+7UNW7bvf7+L/uhVP4ZtAXwHiPjsd1aXVdORWam0k6hu6iuScmFvt+GxAAPS5FA/A9TPkQk/2BXDZbZBFKSa7ubX3NB2yH/SoZ7IL8st4Og8oRSDvtHnJ78+4E/SfNGmyTU/mLex3FKTpcy;3:4zzZI64Qhdkc8jWPMotplGpD/ky27/YEJQ3jHbpXoPfzSDV12szQjvULt0WWrP4lBkAdfLEFuBqlkZYsUQTft4zsm5i9xftsn7F29hqETthwTrGsA6F02RdpHrxvoE4x X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR07MB385; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB385;25:7N04MOcPNutqUnyuymYTMRvC35O9ZcIr9IT2iOhBPZ1geIAn8Ef2L81a+tgDdoBWvogApOUb4T02CwyGaOy3YlYW/M8Dz7mUWWSSWy7rCZ4eRufq3MhQKCs4uS+LXFFUXOOmNb37jTLwizhmZtcWHshclhl1Ps5BkgvkTskQWR89iLvWJmG9xCq8TqIxfKbJHSd/9nOL0Y9p1NCnI4YlK3Yn8DhcUVVLDi+DLtY8nYr50O9S4iEy+MDzeNkUz6iuljutcuHvuQjQeUNL3Me98UTjolNPVZJ+npk3hrotzfUcm+80e7gsFbmNhQEVWGTDCa+fp2bLwhlw/4fXErfjlmzDcVhCt/XbQjXep6sMizIYuUZmbRwGT8DoFmycQxQnw9b+KtKEI7gpmtsl5193gEA75CnEo3GsNxf5DTc0zKXD80L04PwX+zwM2uVZeKIMM2GTkQNVCWDT03F8Vy/oFFY5Vli7+Fl2DWIHf6Ndp6HZprBXe7gu44Qb9hE2MSv3pOxq4NiPQQGap7DzRLDv38/Kcv8bPZSghvvOYbFPKfIlVaA+NDIg4yrVIWMgfM/ZxtIbgPC5odlrc/C1w510KTQCd1d1KwBMgQZKd6R/ltcAUkKIvb3PGun+PmnklmZ7noDAGqyOfsK5ALdh9XTiUC4CQNc9/EpfOmH+izfiIrvX4IDBjv959oWDrz5RWZIAbEoW1T9lMauMjl1esynCWA==;31:AAaDvvSO/mHYmhpraFbk40UoiNvYjZMgww1jYptXbUCyF9m+DbS+UVx3TD7pPfrua9FJ5QjUz1oYvmJB65ItOljIMdRI54x5rJF9jeYz38OChGgBHrQ4eU3eI4vCqTjMSPKuLZT7WqNbg1YNxQELYF+ycYT68fTCgDOT9guxtPqHOrIzRRS8zPM8k0K5BSYlVLB/W2y6vmtqDaLu0IWshHOJ7zWL+rAXKDB0rq+G5yA= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB385;20:aUQ/Js26Yt+JutP8ATpTDsxMveQpsLKgdrbkX70wcObeuW9i26S/KbBtM+ndVYSxcQuWPwwShbVwg8BmPGUSq0rJpTqHSkX/4yDVOLRCso7X7GkEeoijzCvGn5s72B+IzXXXhteYnRMVAr+HutcQp3VK2nS4Rco5P66R5V93avWIrQegzJrpMTGmW+mYzLXpRIptm4iIQcgntyuYPL/Kt+Vttl8r6cy2DmuowpPaUeGl0hNUrXq/xw7BrKXxUsCJ6PYmAKMZ7+ODdl4pPf1aqxjze7Q+b54uxcmQPRb/kdfTwyAnM6hSbR9hG9tA1h48X9n19q26g7xLHUn3VkdnReGM41wGMARrwL76WuXft5Kwpzh9fTeuG//hXBoFO0IYKr8nbTXT5qi8tl/omP1sNVuhhglF20/yoluEV19vd7zWA+xkRayOld5/ihfYB3tvqoyxn9ch90cuMB8OykmhYc7TByogCwtkWrnmVUFNWv40ckqsH/Ro0dJ9bXwUKgEf;4:lKr6mxz77g+mVAD2dW32h6hBF+a20TSWKXAoxhpTO0MV0suOCeefAEA9lJzBtqmU7v7XMpgh918MNRCYErTizDJAbmNwLSukTCAYkVhJDc70lI4pRFX8j9+5JqdHFKQcVAQ19AiGYTm/GR7n/NlbUYC4kWnjls/6rttTjBo2gzFs+1Ltaq7fRX7cvJ5PkDzRLnJd6w6QhSlq3FvXGQF8OLConxeOF9fu2piTJM5+TmFDdU60kEwxwOr+jlJPxzsKAYo/nlCqvUi+FlOZEhsKPabtYIC3ge8zuXup7dlPfEem5OHoJSQJLkGYbgBp/Oc1PNonns3244XHe2s0JrnMj83SlCYMey6dWtQ6zFtZu0txmwwmX/tRAaXJZ5dd4KAg X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:AM3PR07MB385;BCL:0;PCL:0;RULEID:;SRVR:AM3PR07MB385; X-Forefront-PRVS: 007271867D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(377424004)(199003)(377454003)(24454002)(51444003)(189002)(64126003)(81166006)(105586002)(106356001)(2950100001)(36756003)(4326007)(50466002)(31696002)(4001350100001)(65806001)(586003)(83506001)(65956001)(66066001)(6116002)(230700001)(3846002)(68736007)(47776003)(8676002)(97736004)(305945005)(93886004)(4001430100002)(189998001)(107886002)(86362001)(101416001)(31686004)(42186005)(50986999)(19580395003)(76176999)(7846002)(81156014)(7736002)(2906002)(33646002)(23746002)(54356999)(5660300001)(92566002)(65826007)(5001770100001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR07MB385;H:[142.133.110.144];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM3PR07MB385;23:siNtndjfry++xApL1XEIEStswKWotOwkNODVBG?= =?Windows-1252?Q?3zzv6/QPZfymwLu2cA70PY5DTFtx7ET4cx6+7EL+SOjphzb4mwC5AiVh?= =?Windows-1252?Q?LhtG1pxi4K/fxVIEExjz/fgkeD7qodjhOoZ3gkpusuYuuQIlLTZpkL08?= =?Windows-1252?Q?JtwTAavioKVFfwc2vcyAVz3lz4WsTHKSMSnKdHM2wV9CNtLcw9dOmUQn?= =?Windows-1252?Q?R4dsrqVo9BLN1LbAY7HOStyufzgzleXkB/beKTzOp4XaSdJJZUiQqDP1?= =?Windows-1252?Q?1f2jE12T9l4bEOUPcsksCiuFbQcOPunFT8cY3d5D/W0ihuZG5S/dUhWg?= =?Windows-1252?Q?91+ectJUt5KhNJmWpQuUFkcrUSDwqRHhk/LaHu/Kl1njKTeqcOsjPFi6?= =?Windows-1252?Q?ypp5Qg9keLLuP6zL2jdHPXbRz/DCSjRqjEuNGMreesl+ECc4GHz2z5wy?= =?Windows-1252?Q?HtTA87rdxnf+r2TaVM9pN0JTTyIRnX9w/MnN/vMjAZylNlQ9JBft37w1?= =?Windows-1252?Q?uqPUngd1iU0K8/cONkh/CbO7lY2vtfJNjYCPV8d+wetuQRWrIP+LFgT+?= =?Windows-1252?Q?njvkPbTrmIHG/oQ8O5XF9ciBzA4htV43Ospcf4uSyPNxVfJx8qW1KdXg?= =?Windows-1252?Q?OCnf34km5DVzcT4JUXFyydAMbnxlBFJpmz3bwtQnq4uFKSQFqQ/AMwpj?= =?Windows-1252?Q?LRU9xplGsKPUtsd7tRPFWrK/BcH4xWULN3sMu8ZCWQx7WP4nscbWpQAu?= =?Windows-1252?Q?Ykc90nkW9lZ8s0VW0fh5WUJIftwbttLk6idABE1ED5Q8kHSHRXHfgHNb?= =?Windows-1252?Q?GXkiXINY5mQux7bJGDDWWjF/nnaU68G1vgyNAZt1hvjRgUzMJLDA7LtM?= =?Windows-1252?Q?MavL5YBsCXyVVHKErp0SYaczQhjgRUAIXeQMbHQymqQZt3XOYk4d2GW6?= =?Windows-1252?Q?aLtgr4d1YovW9QkntL9h5o9ohqIj5n61glaKzcFbkxV5ndnAHHgbTDro?= =?Windows-1252?Q?X4Mb17hHoy0qtrfp4GKk7OgSY6cYog7+hJCCkciAOYwCCCcIFlC2/VBe?= =?Windows-1252?Q?NG8R47FgguIQ+hBfoeEEurQmr11YYRKTDZfazvqwhuHMhxpo72ydDtMk?= =?Windows-1252?Q?WN+o2G5WXhmnhXeKW3e6b5UVpN32c08F1xDlDTrwIRxcPXYzTgWZuFjf?= =?Windows-1252?Q?6QE0+1qH6ANAQGcN5KXeJwISd4jjbhNhiXjmBi5dztXet8zh+VVC+bIA?= =?Windows-1252?Q?OK+weuOvo0vLeJVKYvmC1U33QyaJyY+6qJCtJCPdyo/ajj2Jw8ZkaoTH?= =?Windows-1252?Q?y43sz6/c3q4Lzb/AHbJCdFqpp2OlIigURCT+te5jV3tca/9LOaqMk+6D?= =?Windows-1252?Q?buFiSuSyCag/H1z/WFHekb53mIgL1iD/Kpvx1sY+2OL1voGiTu+DZnv2?= =?Windows-1252?Q?WkBZOWs08JyxFtkR2uEHvTLGW8/nbph7opr2OcLTDJpLQlh8rPFqggJe?= =?Windows-1252?Q?RunJw=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB385;6:YDuGyzxyxPHlR4qzKCIs6Ud8W+F5GCjtujkUuRz0hGS9SL4Oh2IFGDYey1Djj88lSWlt+gef17DO1CZYv+XFU8pG+aMHK0Orj4W/RqsZIlMlbudFe8Z2xJi4VrMnNEN3xAp4Xq22s1crqnNF860DTnFQIZVXGHwn1o8x0WDAqesF7F9fTdEJQcRFh2R48kM3UIL+4aO83KNQeAJFgpvWPZHyTQG0to4iw9mN5yx4Ax+hBU3CLGg6WMt8qp+l/OKuJHGhI+uMOsJ6y89FvuIfbaiuuDox5Nb7gNw6hBEJEfw=;5:wTaguG2Tf3MdZ4yTYSGlI0RY4NDcRI+16aYYCoCyDGRMPcvC1L2cZuMtG4WFr06U7TKadCldkGrAgNtBl9c9gJeMpCqmzMYO65vGPAJqEjEq2XGgaosmUUVtY2tKKn0DNLrTjwZVaKhlqCt23884CA==;24:1IoJjvaRyNdmxGpLULrMDa3QNNjhosuyuQ65sAlid0XJdnPxTGdIkYCTm0atSV8E7Otyp2cCal4fgoTU69QUKwGzeC5JdO7PDHGuzM12iQ4=;7:aAmvo1mPsxNXYkwDqPpPMnr+gduCThhZT13ZcZL4eeomSVqBMHdQmyzVbtRk9+GFLtW+OOQiY5vEXsqJG8/otShNPZfr2guXl2m1f/9MSpRCOe44zmhQcl1xKCV7boMbtA12igHM6VK3KbBjHlAOydR3EuW+Q/scf7CsuSDFYmiJhGknfAxanKfJZgaHvTx2rvgp5uWkva6zGAejY6g3MPbiUKg+TO+yaHIU/9mnzTRmC8Bujosu/Uj4neo9oncgp8cPq6K5MthIeGsXiZoXlJp6RF+18CetCh05T1xssbly/D9SgQdkCN5bDGa34ePD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2016 18:30:04.8248 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB385 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00270.txt.bz2 On 16-09-21 12:40 PM, Pedro Alves wrote: >> Oops, while trying to rerun the full testsuite, I noticed that it leaves >> "-ex \"set non-stop 1\"" in the GDBFLAGS... that's not good. You can >> see it easily if you swap the order of the "all-stop" and "non-stop" >> variations. Can you spot why the save_vars isn't working as intended? >> When I use a temporary variable instead, it works as intended... > > Did you ever figure this out? As you found and mentioned on IRC, it was a stray invisible character: save_vars { GDBFLAGS } { ... } The result was that GDBFLAGS was saved, instead of GDBFLAGS... I would have searched for so long, so thanks a lot! > What I've done in the past is something very much like your breakpoints > idea. Though, instead of a thread-specific breakpoint, I used a normal > breakpoint + "set scheduler-locking on" to control which thread got to > the breakpoint. See multiple-step-overs.exp, for example. > Using a thread-specific breakpoint maybe makes that a little simpler, > worth a try. I'll try and send an updated patch if it works. >>> gdb_test_multiple ? >> >> Like this? >> >> set test "interrupt thread $inf.2" >> >> send_gdb "interrupt\n" >> gdb_test_multiple "" $test { >> -re "Thread.*2.*stopped" { >> pass $test >> } >> } > > No need for the separate send_gdb call: > > set test "interrupt thread $inf.2" > gdb_test_multiple "interrupt" $test { > -re "Thread.*2.*stopped" { > pass $test > } > } Yep, it works fine with that. >> I think that will go in the same basket as the fact that any MI command >> with --thread currently changes the selected thread silently (without >> any =thread-selected event). Currently, --thread changes the thread tot >> he desired one, then when the mi_cmd_thread_select tries to change the >> thread, it thinks that it was already the current thread, so that an >> event isn't necessary. This should get fixed in the next iteration, >> when we split the concepts of user-selected-ptid and >> internally-selected-ptid. Specifying --thread won't mess with the >> user-selected-ptid, but if you do "-thread-select --thread 2 2", then >> mi_cmd_thread_select will change the user-selected-ptid, generating an >> event. >> >> It's not pretty to leave it like this in the test though. Should I >> create a bug right now and kfail it? Leave it commented out but put a >> better description? > > There's no right or wrong answer, but since you've already written the > bits, I'd be inclined to file bug and kfail. Ok I'll do that. Thanks, Simon