From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by sourceware.org (Postfix) with ESMTPS id A76BC385C426 for ; Wed, 13 May 2020 15:01:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A76BC385C426 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id B06EE16005F for ; Wed, 13 May 2020 17:01:28 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49MdD75LFtz9rxq; Wed, 13 May 2020 17:01:27 +0200 (CEST) Subject: Re: [PATCH v4 1/9] gdb: Move construct_inferior_arguments to gdbsupport To: Simon Marchi , gdb-patches@sourceware.org References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200513094758.523845-1-m.weghorn@posteo.de> <26f19ec4-5dad-263a-48b5-0398d5f3b63c@simark.ca> From: Michael Weghorn Message-ID: <0794e5cc-51a2-67ac-404e-c7175678210a@posteo.de> Date: Wed, 13 May 2020 17:01:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <26f19ec4-5dad-263a-48b5-0398d5f3b63c@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2020 15:01:32 -0000 On 13/05/2020 16.39, Simon Marchi wrote: > On 2020-05-13 5:47 a.m., Michael Weghorn via Gdb-patches wrote: >> This moves the function construct_inferior_arguments from >> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}. >> While at it, also move the function's comment to the header file >> to align with current standards. >> >> The intention is to use it from gdbserver in a follow-up commit. > > Hi Michael, > > The series LGTM. I think all we need now is to wait for your copyright assignment to > be completed? > > Simon > Hi Simon, thank you again for all help. I've signed the copyright assignment last week and sent it by email, but haven't received an FSF-signed version back so far. Michael