Re: [PATCH v2] guile: fix smob exports

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-08-09 11:04 p.m., George Barrett wrote:
> On Tue, Aug 10, 2021 at 11:02:00 +1000, Simon Marchi wrote:
>> I didn't understand though from your explanation what consequence the
>> bad behavior has.  What did it prevent a Guile user to do?
> 
> Ah, sorry. There is a range of cases in which it's necessary or
> convenient to be able to refer to a GDB smob type, for instance:
>  - Pattern matching based on the type of a value.
>  - Defining GOOPS methods handling values from GDB (GOOPS methods
>    typically use dynamic dispatch based on the types of the arguments).
>  - Type-checking assertions when applying some defensive programming on
>    an interface.
>  - Generally any other situation one might encounter in a dynamically
>    typed language that might need some introspection.
> 
> If you're more familiar with Python, it would be quite similar to being
> unable to refer to the classes exported from the GDB module (which is to
> say: not crippling for the most part, but makes certain tasks more
> difficult than necessary).
> 
> Should I resubmit the patch with something like the above explanation
> included in the commit message?
> 
>> I'm fine with you merging the patch.
> 
> Great! Assuming the answer to the above question is 'no', would you mind
> pushing it on my behalf?

Thanks a lot, done with the extra explanation you gave above added to
the commit message.

Simon