From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 374D03858D33 for ; Thu, 18 Apr 2024 14:32:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 374D03858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 374D03858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713450767; cv=none; b=e9aBcHRRJN0UbJClYMtejwZIpZwUS9Z3xxRBdoRRo1U4yNPuh1bK4cMuILuKxYNCF14nnOrEYJZGZqbQOIMvpSUvE+q3ms9cDPaWBvTnd+QU27/lcsaE/blrXBOM0ZMbYigicUW6zeysGtkTmgGyOV17RZcC3B2r+2MpdX9KWMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713450767; c=relaxed/simple; bh=irGjdofFMq5mVxiVatRwgJdvmyfPpJCx4Tdoqnq+Uno=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=A6Ri4gKo+hoXMtSs0YyK75St9OScQczBhd6MU8fuRMRq+N9k8b2fLwqC4pNWpMoFv+38Isu/PcAUxW3ctBvQhVXDClrhDvWUftXHM251br0B1wk0JLL01nk1yzb2FuOkZnereZFE5CYwnmhOT8Gj0pAkBTr1JOP5byUnbflyzeU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43IEWVbT056259 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 18 Apr 2024 10:32:36 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43IEWVbT056259 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1713450756; bh=VdY0raa7LnjSacQ/QXWtDlIKYFy32laGisRCL166pyk=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=JqRv+rjmpgWtzR/Su7K4fIUbe+iobrmMpCeyLVwL3OgWtIZrmnJWj9adtrnuaH0fd KcioO+yXfF0doZi/pE0yYdckp5pI2wlKTweUMQraS5hQ33tU++nq0po5WgYppZzCR8 jRmE9YBCzp0j2cPQOkrzWPKUAi43bCLP7K3nLKss= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 531B81E092; Thu, 18 Apr 2024 10:32:31 -0400 (EDT) Message-ID: <07e698c9-37f6-4276-8ce9-327fea79d995@polymtl.ca> Date: Thu, 18 Apr 2024 10:32:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport: constify some return values in print-utils.{h, cc} To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240417205530.2033347-1-simon.marchi@polymtl.ca> <87o7a6zrqz.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87o7a6zrqz.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 18 Apr 2024 14:32:31 +0000 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-18 10:10, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> There is no reason the callers of these functions need to change the > Simon> returned string, so change the `char *` return types to `const char *`. > > Simon> Update a few callers to also use `const char *`. > > Seems reasonable to me. > > Approved-By: Tom Tromey > > Tom Thanks, pushed. Simon