From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id DE01F3858C66 for ; Tue, 17 Oct 2023 00:26:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DE01F3858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DE01F3858C66 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697502399; cv=pass; b=XW3tsJM1VMvzvsAJrApGNG39GW/sHAfRmKQGTjSYL2dEktTKKg+xROEJa+dlKWpcH3+fw1ySjQTjLrpJ8QCpXOHeGu2OtPdyBHfmudglX7gVZLYhFCXlelM24Lp99MfxFC9wMCh5DvnTX2MRComhY0S9w6xGozmXzXynRd9FztY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697502399; c=relaxed/simple; bh=oGcfz6G9QL9XeDSw5/dBGBcgGfs/Zjy/cwlcDhSV1ag=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=dPc90zPvlzDbQS1KR6TD3cnp4L/lFhKGJ3lQagOHWi2bmUDYG6bQW9HpPDd7EGsPVW8qjXJySFVRBZmUORUwlkEGlds/UmmGKmsqYEU7xW/BU8llinKGjqz8olUtwqfAHSrL2fgAg6IBD1UcWlMYZu6N+O4jwph4lPSYIzylTgI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4S8ZXq4Hdnz3gY0; Tue, 17 Oct 2023 00:26:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S8ZXq3RJxz3Mcj; Tue, 17 Oct 2023 00:26:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697502395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FgIYQlm+YuWUiBzacLbu/u70pyhT8XCaBZki80VUZq0=; b=xhhhr2z0BfD0hOkdHyiukOr322gPtUFBm9iOZb/PbjTlP0eUmpbjj8JGs1UP1cKAeRzQyC 0LWWh+G3c/bl2ItrK6qVCfU5NNW5ApJZAl7Bc/J1RThD+ubVGNYiEpfvNDlYQVcs4d8AOI CPGLp5/2mVtVW+6WJtFIvi7FnMlhOPvvl4FZwvkPHlctF9bvvnnzLnHr2UEyAXBWA4s6fk tRtnIE9bADS65leT69H23Xqq97n6XS+ZPgLzbiCXhw0xkwvNgQunSypdXXVpUxVYHdd4i8 9Lehu9Np73FpsYWGLzOJwbBwT4INRvv8AtCOBcFQbA13gHlCGn0VFValc6WdjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697502395; a=rsa-sha256; cv=none; b=y3wKvmECnJ5cEWyFLTyUvbF8s153ivgvFrcD51qPcG0mS6FyFGKNhcqKDKbm2552Hgjl34 22tvxTpl2Yqt7vNeTTq6aX2OQQRu5QbjJDnYeMXkdvxxa5BDC8P/h5ajXTzWgduekhMOWg p9dN3sELVXc0KDqqDpuw+ZSDadGw2nH4WehPthoiVHBD4ZgCNfQKDEPVIDutl9AUpYCkSe 1AIuDkXCr8UYfB57nDADzlHV+tm22dkudzz1QwZPu8JwI6hMF58BJSo4Rjlg4NN3t04IK+ 0iT4mcyhkJn+dhVnM0gK2yr6F+v2mcCURNGimtz++lYiLLigYvHTXWSkK/eS5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697502395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FgIYQlm+YuWUiBzacLbu/u70pyhT8XCaBZki80VUZq0=; b=HxaBw+OAvF7rBLrDRsOxoGNLrXqZnX6k8plRf5f5ztXKacXH8d4ItWWUOWLH9Njx7WbxBS Vbz54CU5CgqDyYA/FP0DiKhVcEThxmhJ5im3wV7Q3aGwwweKtKq2rq4O7wjLmtnWX3hr0U Vq9wug8mauQBsb1GwMMnzwSXcSRVuX6Xz8EMBE8BQ47FDTbDvANBxlfOU3BlWVz0OkqEfs i3td4Ha/QI0fFhIeN7Tf4bwJMTgpnw/x2hiWiwZTLtfcYvkNb5f3RYac9iBf2zt6cJ7Xpa kYjqCsQMIaKqQQcyR6OGv0/TjuznuNOuuQKaHca4puGSNsKZXpdxQSNR0XbK9Q== Received: from [IPV6:2601:648:8683:39a0:f055:f679:76c4:bebe] (unknown [IPv6:2601:648:8683:39a0:f055:f679:76c4:bebe]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S8ZXp60qMzvJ7; Tue, 17 Oct 2023 00:26:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <07e89c02-7523-b9a4-956a-014306a6d660@FreeBSD.org> Date: Mon, 16 Oct 2023 17:26:33 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [RFC 10/13] {amd64, i386}-fbsd-tdep: Include NT_X86_CPUID notes in core dumps from gcore Content-Language: en-US To: Lancelot SIX Cc: gdb-patches@sourceware.org, Felix , Jini Susan , Simon Marchi References: <20231009183617.24862-1-jhb@FreeBSD.org> <20231009183617.24862-11-jhb@FreeBSD.org> <20231016093152.pu5xmxf32gc4ptjg@octopus> From: John Baldwin In-Reply-To: <20231016093152.pu5xmxf32gc4ptjg@octopus> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/16/23 2:31 AM, Lancelot SIX wrote: > Hi, > > Just a forating nit below (again, feel free to discard as this is a RFC > series) > > On Mon, Oct 09, 2023 at 11:36:12AM -0700, John Baldwin wrote: >> Override the gdbarch make_corefile_notes method for the FreeBSD x86 >> arches with a new function that calls fbsd_make_corefile_notes and >> x86_elf_make_cpuid_note to generate the core dump notes. >> --- >> gdb/amd64-fbsd-tdep.c | 1 + >> gdb/i386-fbsd-tdep.c | 15 +++++++++++++++ >> gdb/i386-fbsd-tdep.h | 7 +++++++ >> 3 files changed, 23 insertions(+) >> >> diff --git a/gdb/i386-fbsd-tdep.c b/gdb/i386-fbsd-tdep.c >> index 1789f3921fd..810ecc90df1 100644 >> --- a/gdb/i386-fbsd-tdep.c >> +++ b/gdb/i386-fbsd-tdep.c >> @@ -26,6 +26,7 @@ >> #include "tramp-frame.h" >> #include "i386-fbsd-tdep.h" >> >> +#include "x86-tdep.h" >> #include "i386-tdep.h" >> #include "i387-tdep.h" >> #include "fbsd-tdep.h" >> @@ -370,6 +371,19 @@ i386fbsd_get_thread_local_address (struct gdbarch *gdbarch, ptid_t ptid, >> return fbsd_get_thread_local_address (gdbarch, dtv_addr, lm_addr, offset); >> } >> >> +/* See i386-fbsd-tdep.h. */ >> + >> +gdb::unique_xmalloc_ptr >> +i386_fbsd_make_corefile_notes (struct gdbarch *gdbarch, bfd *obfd, >> + int *note_size) >> +{ >> + gdb::unique_xmalloc_ptr note_data = >> + fbsd_make_corefile_notes (gdbarch, obfd, note_size); > > In GDB's coding style, the linebreak should be before the "=". Thanks, fixed here and in the final patch. -- John Baldwin