From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 17C623858C60 for ; Thu, 30 Nov 2023 11:37:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17C623858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 17C623858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701344221; cv=none; b=qBnHY0bC/YV+lStVZ8u50DAo/y0l3InxuNYxpJc1mbVHhDf60IhG3M+3OGKGWGt6boX55hg9Ty73/TeDlJJ2RFUdEhXv4Jwk68zbHBI2XlFkhQl7XZRAaXwZwz4l/YH5y8Cbi14dVcI+WA0bgh6K/sjRvSvUcBTGA32mOQKAt9M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701344221; c=relaxed/simple; bh=7hQppVR51RA7/GZHOnp3rADMLFmlht3c2lJ6uicutas=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Pj/Nje/QABlHGGOFi+KXi92kYwnPwYQYgnkcH6W4q7ieipS38Uz5NfLhbIz1rjOJtZpmrb6xuX1xv5WJdLDZ3teHXzYDDYCod04Ov6cWf3+3QE0jEGw5UTPJ8CKgqXU1qKTWn8jMDBpl1FopjCqMsr2PhUN1KsgM5mMWQ/mNef8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701344219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9Z0CgzJS+FtLmdziGUzBp229UkSnQNSlOkWN6WliL1M=; b=HoWH50fc5tDQo4945egERj6j04hO7I1FohY2AR0qbsYVVASoZkqKCEL9/F+XQifNc/d0LC VQFgZwEH8KJcm6zo4c9EFE6xM4r6pl8DOPIpLS6Mcp1192WNUCplO7BZabPBKQ1FHfh0zZ sTa1qpV3MT1KTSdo319s5nMdnGFI5pA= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-ZH7joNBHMp-4vyLHTc7b-g-1; Thu, 30 Nov 2023 06:36:58 -0500 X-MC-Unique: ZH7joNBHMp-4vyLHTc7b-g-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a114f099bebso79077966b.2 for ; Thu, 30 Nov 2023 03:36:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701344217; x=1701949017; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9Z0CgzJS+FtLmdziGUzBp229UkSnQNSlOkWN6WliL1M=; b=m9g1suEv/TcLXzP6uzIT/bT6Fvnj11uAGLfUilvreBLRssjPMebKPrGudqmP7+Xs0b oZzcZZn8o/sv+bVrIxLv4sXFAcGUqBAoDbikodjIbEbpV6HhB8zzU/1mYwYaWNBSW4Qu nCbohITn0NGeoWDfEEMrNtdXmrqzUCb3ZUx3vmd9/ZxZunbt6GBKSFkPIQpv078gZ1BS YuFTiK/HdNdXlP+LdnpoRsYCwP9fjr/2QtrTEyjqr2GoV+AMMYgccHg5lcQyRNADpnLx 8xGZz3X1R/DTKaMvkKVTbLnbpFw8PJFEbVhP2FQK29geoePEu4UHofQdMvrZGeqiMrpN J9Yg== X-Gm-Message-State: AOJu0Yy4bRq+QVY8gKYsrquoPkgoAi9uSMjVYe0MXqxjx2/69xizHzsF 3PeQ7EyOF3vJbAcx98ZnYdfkCC/gvHL+sMKktCe/eukaJg9OzksAqlrXaz4HVzPdLxdcn3qFabR ZkBaalJFEsk3HNEu+9dT4VA== X-Received: by 2002:a17:906:798:b0:a0d:ac30:4963 with SMTP id l24-20020a170906079800b00a0dac304963mr8384426ejc.76.1701344217321; Thu, 30 Nov 2023 03:36:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IGoDuOmAgsR2NYHCwezloDhXLY/va0mj6ZQy+rCgjQ62kIQBYCynL+tEi6z+c2C0IKpZE6Gvg== X-Received: by 2002:a17:906:798:b0:a0d:ac30:4963 with SMTP id l24-20020a170906079800b00a0dac304963mr8384415ejc.76.1701344216975; Thu, 30 Nov 2023 03:36:56 -0800 (PST) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id 9-20020a170906100900b009ddaf5ebb6fsm576619ejm.177.2023.11.30.03.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 03:36:56 -0800 (PST) Message-ID: <07f044da-94d5-bc7d-7d57-d83e9f179e59@redhat.com> Date: Thu, 30 Nov 2023 12:36:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [ PATCH 0/3] Fix GDB reverse execution behavior To: Carl Love , Luis Machado , Ulrich Weigand , gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Simon Marchi References: <890101c23dd5fa60fcbf9d4b299cb2a533c260b7.camel@linux.ibm.com> <1e702d8f-e5b4-4719-b1e7-42210f350305@arm.com> <643afce1-ab9b-4e8b-bcbb-5738dc409a28@arm.com> <9e17008084c34f953f5318933436ec703250120a.camel@linux.ibm.com> <92a751d1-a4b9-4c21-821e-a1dc67207516@arm.com> <5483d77c72088a1e4d5dfed2eded2366643fc659.camel@linux.ibm.com> From: Guinevere Larsen In-Reply-To: <5483d77c72088a1e4d5dfed2eded2366643fc659.camel@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/11/2023 00:33, Carl Love wrote: > GDB developers: > > The patch "[PATCH 2/2 ver 8] Fix reverse stepping multiple contiguous > PC ranges over the line table", > > https://sourceware.org/pipermail/gdb-patches/2023-August/201889.html > > was posted and pinged several times without any response from the > developers. It was reviewed by Guinevere Larsen. The original patch 2 > was intended to fix failures on PowerPC and AArch64. An additional > architecture independent change and test was added per feedback from > the community. > > Based on some private discussions on how best to get the patch > approved, it was suggested that I should break the patch in two to make > it easier to review. Specifically, separate out the PowerPC and > AArch64 fixes from the generic architecture independent changes. The > original patch 2 has been split up as suggested. The hope is this will > make it easier to review and get approval. > > The two new patches are functionally identical to the previously posted > patch 2. > > The patch series now consists of three patches. > > Patch 1, adds a new option to gdb_compile to either generate or not > generate the line table information. No change from the prior version. > > Patch 2, fix the specific GDB issues with reverse stepping over a line > with multiple statements in the same line for PowerPC and AArch64. > Behavior on X86-64 did not change. > > Patch 3, fix the behavior of GDB for all architectures when executing > the next command in reverse on a line that contains multiple function > calls. > > The series of three patches has been tested on PowerPC, X86 and AArch64 > with no regression errors. Please let me know if these patches are > acceptable for mainline. Note, Luis Machado did the AArch64 testing. > Thanks. > > Carl > > I've taken a look at this and also see no regressions. I seem to recall them fixing a clang regression at some point, which they don't anymore, but these have been in the works for so long I think its better to take them as is and check the clang regression later. Reviewed-By: Guinevere Larsen On a side note, b4 didn't really like this series and I'm not sure why. My guess is that all 3 patches have the same email subject, but it may also be that I needed --3way when using git am. Either way, just mentioning to gather knowledge on what b4 likes or doesn't like. -- Cheers, Guinevere Larsen She/Her/Hers