From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2079.outbound.protection.outlook.com [40.107.241.79]) by sourceware.org (Postfix) with ESMTPS id EBFBE3858D32 for ; Thu, 1 Dec 2022 13:49:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EBFBE3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSTsnwMcdo8Oin7TbanIiAcKRaIh+MPWW8obJ3h5F7TpoR4iB+cQY+qMzM5bwk+7vfIiv9IC8bF+anYTbGMVfdeCkgp4iOPtSyjTsPcCM/snYUu87xzGeBdarSJMv1KoIrORcZEfKpOcKAFfGtRu3ifJva5WvxOWK5qsS6UY264N6bzgrbpF3zXIREDeZRUAx0bx09r0XrBvhH822FxCIaAhGGJ7lDMbmCs+SspWstc9HgWOXYpXWIgZtJulRzFuOzL9zkaSNLP5rzZUEAX2beivhA2lpbdfJD9iYL2BvaPzf2YhBL5FKbCmCDYmmyjFNF2bsrYZmcA1vQ3cUCPo2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1pMggqaOwwakKVFVOf3lXQxe74t3dGZP1mDoxwfe64M=; b=Po1IDy4J711oyp5hUe9/HQ9hJ/XSKTSDRy6r8kE9lK6eLXKs1sg7mCilIoFwmIkDOl06y81UpQ/D+waFY6SD9o3bQ3QXeIRWMWnX7SJ0Wjmm8HGFi1RStrhI8ngq1sLIcTW7KAxDEDyfBcKSjneGSIfCy7UDSUz98Es+z9Duks1ug5opVHLuit6oi0LV9HKll5ikdjuFGdFyLtHb1fy8FzuEsheaSEHEyuswEug04InKaBAj5IgMwaXUvh2Dyl0kjbf8PzeS/WHWD5dqDUE1vVimYNlWCjI1aPileZwzCX1Lo9oA4YBZIFOjeopw0HyBZdAmHTFF2kbWkShFRRGfEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pMggqaOwwakKVFVOf3lXQxe74t3dGZP1mDoxwfe64M=; b=kEq7/chJgd2/895eVHdIw8LsU2x7kvl/qZnYirdhj78x+d1f9QTwVLRgIVFQK/7Dbu3cCCRdvEcfkbQulLxzWpTjgtSPecAMXcvpVQ8eEcFstfnH40XcvrjaJTfIt/xEhM3xdrpq4ZAqy19UF4Q3/fkW7GeM6oyxC1PC88uJsi0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by GV2PR08MB9949.eurprd08.prod.outlook.com (2603:10a6:150:ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.8; Thu, 1 Dec 2022 13:49:04 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::fe5c:b195:a2ad:b19c]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::fe5c:b195:a2ad:b19c%4]) with mapi id 15.20.5880.008; Thu, 1 Dec 2022 13:49:04 +0000 Message-ID: <0839ffa1-e99b-a6a5-ac01-d8e3fb5fdf1b@arm.com> Date: Thu, 1 Dec 2022 13:49:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.ada/float-bits.exp for powerpc64le Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org Cc: Carl Love , Ulrich Weigand References: <20221130140006.25890-1-tdevries@suse.de> From: Luis Machado In-Reply-To: <20221130140006.25890-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0022.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::7) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|GV2PR08MB9949:EE_ X-MS-Office365-Filtering-Correlation-Id: 557106ac-720f-4f91-2802-08dad3a2cf62 NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A4EM6XxlYV3aCuMy9GOHBcK8ITmIrOU/EmUe75RlPRUqENAm9k26mKTGrEybb/SEKHpbq9joKgcykxNUnEZqIc9+aqR1TRONt/fY46LRVlxEobKmFo3o9DHfjF2xB2mxDZWOgLneT9lxqYkyrJe7zRqMp94bU8PZzfs4N/zkAdiielobZKYiazIbRDYB00wznjGDJOA3VzBlRzKjsexd8Kj4qANvRqVjFj3fUmOacAJ0MiPumKgeJEoyhAEImXgPecOJNo1UnGWmX4i1pZEGVsfvSHXMWxRn9ea3JygZ6UFe3epNa2cJ89xqh3MtHIXi9YYUl0bF6/YXc8oWEVIDwt37UldrlJXh4nsP87Uq04DiXyPjeksE2DXla/w5PZZIL39GOBtSTcUDRb7kGohOV1yCDpN1GypuHIHn7o97OwAGEPrgZ9J15SYWgQ2BVrGsJ9lsjJF8Ry9+8sKFkxLLyQ/VRAAaQ74USiyGYl0aIvXghupFjuEFdFc3EeBNTCkJgMeyAVa/aKojqckYqNJgcnCzBcOy9BwCBwIJY2QDxBd3YUZ9KfOyOhzbL3905LUYQ+CvNw1fKhmUxIKYZqh7lnRdI06AfAwMqz+EV7u/d6fTFAZXCqkuAVKnJbsv8Youa8TI83jw9GqjZJU8E9+9+TSyiE/hISHFmhpFdG/zFQHSKtsZ0t+0ORfcikT53m4PhUAuqk6jeQjcgt3vhea1TRXZ71mev+pq0YgB7kDmeNSMMiIlASZ+7NCdGhUK75q2 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(451199015)(83380400001)(86362001)(31696002)(66556008)(2906002)(38100700002)(4326008)(44832011)(41300700001)(5660300002)(6486002)(186003)(6512007)(6666004)(6506007)(8676002)(8936002)(26005)(53546011)(2616005)(478600001)(66946007)(54906003)(966005)(31686004)(316002)(36756003)(84970400001)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1JwZ1NZeWFZaHVGTW5oQTlpbU9VRzVNKzBSMXp1c0l4RVk4WHBTSVlKeldW?= =?utf-8?B?WWpLdmVzMWdnOXhQZWtndkUyYTJYSEM4NjBXOWhYUWxJU25TbklWTkFmeVI4?= =?utf-8?B?dkczN1EvOWxCZHlJUFY0WUpnQWhHT2pLK1liVmJ1Uk93TFcxdXNSVUNMVzBP?= =?utf-8?B?Z28vaXJMTHJ1K0Q1NUFoS1NOSXRuNDQwblp4SEpqRzNCR00xcWFIanVhWkU0?= =?utf-8?B?aEJQeTc2KzluSnl2Uzh2YVZtWEF1RU5samt1NDFjT01JR3k5TDFSblZYZlgw?= =?utf-8?B?R0kyaWVGN3VhN3RvZ2s3SXhxUWFQM3BkMUFsT3F5Q2c4QXE0c1BRaTdCdlBt?= =?utf-8?B?ZU16MVFqSGdoTVpySXNOWHlKeVVmSHpVNDZFQlhEZTFNNzNNT01yUXpTZHhK?= =?utf-8?B?TzlxMFE0UkxDQ2hzMWxnT3RGUy84MVo4OThKTEczSUNoTW5CMjJmbmlteEVl?= =?utf-8?B?YnM0cHgzNWdlRytHcGtXMGtzMFJUcFFBWVZXcDk5cTQ3ZzZaL3dycEJSL1Nw?= =?utf-8?B?aXNXa1BMdUkrTlBRZTFVOTMvMmx2Y09BUldZemE4L1pDbHJXa1VjdkFmOElH?= =?utf-8?B?QWZ4bE5KbkJRWkJTdTVLSjZWMjUyK1llV3JnUUUrVmtFdHhYTDg1NzRVWXVj?= =?utf-8?B?RU1rVXpMdndLVGdmVkdkSzBvL1FjY1YvVWxtZUZtY2x0a3YrRXNEUzB0QkNa?= =?utf-8?B?cDhGZm96Q3hLc2twN3llUHJyVDBEeVhDQ1VycG5wd0p1cmN1WnM3ek1makFR?= =?utf-8?B?SWRmc2s5dHJtZk12azNmYWNRUFhOY0pFWVB2akFWd2k5N2dpMXdKOU0xWklF?= =?utf-8?B?YjAxdnd6b2RsTXJZYzMxeWN1ZlhFSm9oVHZjdThBZDRiaTU2QUxqelhhUGdZ?= =?utf-8?B?SVFvbUxXYmN2bGpXUFJUeitCK2ZoaGd2dFNmdldhQU4relJuSXgzVU1yaldX?= =?utf-8?B?N0tYeTE1MUtNQ0crbldrS3J6blhIWCtnZFBKNG5ueHhlcmdiNUMxMTBmNktJ?= =?utf-8?B?MDZ5RzFjRUM0UXRkMG8xTlV6OUNGVUpGR2F2a1I3b1dhdStCNkJQQVpaUkFh?= =?utf-8?B?ak0wVWk0bVpERW5SaCtMb3g5TVdMRVc0WHFEZTFuTWVKMDhBbEh1NlN0S0JC?= =?utf-8?B?eUVGL0s3a25FWkhMcEZBV29LRGdvbmM1MUsya2QzNHhvaUhzSlhvRXU3cStU?= =?utf-8?B?NkpJOEk3SkFVMlBZVVFDaGg0NHQ2ei9rOVp2WTlJemxJN3FNS0FZM2RScUg3?= =?utf-8?B?bm0rN2FUNUxkRmtudjRxNDJpNlpLcWR4RG5VdzB0bXdtRTM2L25OTHhNN3Er?= =?utf-8?B?VGRlZFZub0pCSmJVay9jUmhSTytLd25GTmNxV1pYTysySGhlSTBwSGtFQ3Ar?= =?utf-8?B?c0IyTG5YTFVzODR3N01xUGZuaVJTN2w1YUZrbGV6K3h6cUEyV3dnZkxhZFFV?= =?utf-8?B?MXh2UDc1MmtEazk2b1FRZlRCYkxUQUt4MEtZcXVuUlFqSFY1dlI5NWlYakV6?= =?utf-8?B?a1pVQ0lITVVHL3NiT20vSExhc21SQ0VHWXlzcTR0YjNIRFVkQzRQemVKVUVG?= =?utf-8?B?M1V3WlNXMXBlbGhrdGlTUDdWNlRvc2IxSmhPeXZnMlUwSVBURklWQURVVkZV?= =?utf-8?B?ZkQ0NHpkVHl2am9iZVpQWnk5WkU2RnU1dGhianRUVGc0V2puVEROYklQelRP?= =?utf-8?B?QnVHbWF6dENpMWFnM2RmR1N0eUtqaGZCRXNQY1g4cHRrZ1JCUHF0YU1aa3Rt?= =?utf-8?B?YXFCdURpbVg2OXNuY0RSNVl2UTk5TEJKYUE3Y0NaMElmRFZsMUZpSGxZTGF3?= =?utf-8?B?NlA3dVRCVy9aZW85bWhmbWpJNGhqSVUzcTBoK0FaVmJqUmQ4VEJqOEJRVDRz?= =?utf-8?B?RmJhb1l5Q2djTlVuTUliRURYSXF6QUZOcTVGc3lMNWRlU2U4M3RadmsvY1p2?= =?utf-8?B?K0hoMGV6N2NUYlhFdW5yazF2VVVPV1J6ZHNzclllRXBCSk04cnYyaDBZQmVE?= =?utf-8?B?V2RRVEZnVE5FQ2NiRDk1NE5xbmw1aFh3T1dLQVpwSEgrWHhFamZvenl0TVg5?= =?utf-8?B?OHgwbjlqZXJvZDU3THQ1L0M5SUg4V21jWXJCZ3Z4NE54NmZwdHZ3UVE1cFdJ?= =?utf-8?Q?lLx7lgg8ZCsbEH9v/L03c9yz3?= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 557106ac-720f-4f91-2802-08dad3a2cf62 X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB3919.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2022 13:49:04.5388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2UOMDWwdiPnafELCde7VtAnHWiaXL7jh6wO8qFY0PZ846SSjzOmhUJZCnpgvse+WUgCDhuzqxkEv9/yuH7ksRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9949 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This change seems to be causing a timeout on aarch64-linux Ubuntu 22.04. FAIL: gdb.ada/float-bits.exp: maint print architecture (timeout) # of expected passes 12 # of unexpected failures 1 It is as if the listing of the architecture fields didn't have time to finish. On 11/30/22 14:00, Tom de Vries via Gdb-patches wrote: > On powerpc64le-linux, I run into: > ... > (gdb) print 16llf#4000921fb54442d18469898cc51701b8#^M > $9 = ^M > (gdb) FAIL: gdb.ada/float-bits.exp: print \ > 16llf#4000921fb54442d18469898cc51701b8# > ... > > The problem is that we're using a hex string for the 128-bit IEEE quad long > double format, but the actual long double float format is: > ... > gdbarch_dump: long_double_format = floatformat_ibm_long_double_little^M > ... > > Fix this by using the hex string obtained by compiling test.c: > ... > long double a = 5.0e+25L; > ... > like so: > ... > $ gcc -mlittle test.c -c -g > ... > and running gdb: > ... > $ gdb -q -batch test.o -ex "p /x a" > $1 = 0xc1e1c000000000004544adf4b7320335 > ... > and likewise for -mbig: > ... > $ gdb -q -batch test.o -ex "p /x a" > $1 = 0x4544adf4b7320335c1e1c00000000000 > ... > > Tested on powerpc64le-linux. > > I excercised the case of floatformat_ibm_long_double_big by > using "set endian big" in the test-case. > > Note that for this patch to work correctly, recent commit aaa79cd62b8 ("[gdb] > Improve printing of float formats") is required. > > PR testsuite/29816 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29816 > --- > gdb/testsuite/gdb.ada/float-bits.exp | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/gdb/testsuite/gdb.ada/float-bits.exp b/gdb/testsuite/gdb.ada/float-bits.exp > index 55a0566580c..921fe36a4bd 100644 > --- a/gdb/testsuite/gdb.ada/float-bits.exp > +++ b/gdb/testsuite/gdb.ada/float-bits.exp > @@ -73,12 +73,40 @@ set gdb_long_double_size [float_size "16llf#0#" ] > # example, IEEE quad versus i387 long doubles. Account for that in the > # tests below. > > +# Get the used long double format. > +set long_double_format "" > +gdb_test_multiple "maint print architecture" "" { > + -re "\r\ngdbarch_dump: long_double_format = (\[^\r\n\]*)" { > + set long_double_format $expect_out(1,string) > + exp_continue > + } > + -re -wrap "" { > + pass $gdb_test_name > + } > +} > + > # Set default values for 128-bit IEEE quad long doubles. > set valid_long_double "16llf#4000921fb54442d18469898cc51701b8#" > set printed_long_double "3.1415926535897932384626433832795028" > set invalid_long_double "" > set has_invalid_long_double 0 > > +switch -glob $long_double_format { > + floatformat_ibm_long_double_* { > + set w1 c1e1c00000000000 > + set w2 4544adf4b7320335 > + switch $long_double_format { > + floatformat_ibm_long_double_big { > + set valid_long_double "16llf#$w2$w1#" > + } > + floatformat_ibm_long_double_little { > + set valid_long_double "16llf#$w1$w2#" > + } > + } > + set printed_long_double "50000000000000000000000000.0" > + } > +} > + > if { [istarget x86_64-*-* ] || [istarget i?86-*-*] } { > # i387 long double have invalid values > set has_invalid_long_double 1 > > base-commit: aaa79cd62b873be672e3163eb267513c97ec4399