From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EB86B3875B65 for ; Tue, 6 Dec 2022 15:44:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EB86B3875B65 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2B6FhE4i009002 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 6 Dec 2022 10:43:19 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2B6FhE4i009002 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1670341399; bh=yIbdIumWxVUSXWKDysxEbxKmgcIvjEkCUxP412+OWYk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dP5bkztKRYbM7rBJgv9OBj7DcrSLnfrpp42zOk9AEV0T/NzPGJ3XIWiOAt3vDSnf/ 7FwYZdxRYMatKLZz8GmZRf7Qas+g4bxDsUF0sxFWFD3DMmplAQV1OE1ajq9pI2YZBg HH2BvYOe2elYxV6irUTN0ZIqpJqjsvLQ14Dle7K8= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4526A1E112; Tue, 6 Dec 2022 10:43:14 -0500 (EST) Message-ID: <0880f1d0-7983-e6f7-b66e-f08bb31bf975@polymtl.ca> Date: Tue, 6 Dec 2022 10:43:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [pushed] gdb: make frame_register static Content-Language: en-US To: Lancelot SIX , Simon Marchi Cc: gdb-patches@sourceware.org References: <20221201183249.1062823-1-simon.marchi@efficios.com> <20221206145202.lah7uwybcvv4akqi@octopus> From: Simon Marchi In-Reply-To: <20221206145202.lah7uwybcvv4akqi@octopus> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 6 Dec 2022 15:43:14 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/6/22 09:52, Lancelot SIX wrote: > Hi Simon, > > The function frame_register is used outside of frame.c in the rocgdb > downstream port. Do you think we could revert this patch here? > Otherwise, this can be a change we keep downstream. I think it would make sense to make the function non-static in the downstream port, and then provide a patch that makes it non-static upstream when submitting the code that needs it outside of frame.c. Here, I happen to be involved in this port, but that is what I would answer to anybody else in the same situation. Simon