From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48360 invoked by alias); 29 May 2018 15:55:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48277 invoked by uid 89); 29 May 2018 15:55:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=alright, super, perfect X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 May 2018 15:55:14 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 473FE40BC04C; Tue, 29 May 2018 15:55:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id C70461117620; Tue, 29 May 2018 15:55:11 +0000 (UTC) Subject: Re: [RFA 0/9] Radically simplify the complaint system To: Tom Tromey References: <20180522050704.10845-1-tom@tromey.com> <190d88e2-35a5-9dc2-8b28-4a8c37e0617a@redhat.com> <87d0xmfodf.fsf@tromey.com> <8736yczdj3.fsf@tromey.com> <87tvqrxwon.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <08cd322f-d240-e042-8933-293e096be1eb@redhat.com> Date: Tue, 29 May 2018 16:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87tvqrxwon.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00767.txt.bz2 On 05/28/2018 11:06 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > [ QUIT ] > Pedro> And then when that happens, 'complaints.c'::series is not > Pedro> restored back [because the clear_complaints call is skipped, > Pedro> because it is not exception safe], so all the following > Pedro> complaints are issued with SHORT_FIRST_MESSAGE: > > Hah, oops. I have a series now to remove SHORT_FIRST_MESSAGE. Alright. > It still > won't be perfect here -- there's no cleanup object still and so you > could in theory see too many complaints if you C-c at the wrong time. > I don't think that is super important though. Probably wouldn't be hard to fix I guess. > I was tempted to just remove it entirely, > but it is nice to be able to throttle the messages, since ordinarily > there are many of the same kind in a given objfile. Yeah, I don't think we want to lose that feature. Thanks, Pedro Alves