On 1/13/21 8:47 PM, Andrew Burgess wrote:
> All of the above is really just a way to select between two different
> output patterns, the choice of which is based on the length of argv.
> 
> So, could we not just skip the complexity, and instead do:
> 
>     set argv_value [get_hexadecimal_valueof "argv" "??"]
>     if { [string length $argv_value] > 12 } {
>        # Choose the first pattern...
>     } else {
>        # Choose the second pattern...
>     }
>     foreach_with_prefix width {20 30} {
>       # Run the tests using the selected pattern...
>     }
> 
> Seems like this might be a simpler solution?

In my mind, the pattern matching is the easier solution, and the picking
apart the line buildup and determining where it is wrapped the more
complex (and more fragile) one.  But agreed, the resulting code is less
complex.

Updated the patch to use the approach you suggested, and committed.

Thanks,
- Tom