From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH + 12.1] Fix bug in Ada number lexing
Date: Fri, 8 Apr 2022 20:31:14 +0100 [thread overview]
Message-ID: <09061b06-e134-744d-0a34-3c24bb830d66@palves.net> (raw)
In-Reply-To: <20220408192738.2352511-1-tromey@adacore.com>
On 2022-04-08 20:27, Tom Tromey via Gdb-patches wrote:
> On irc, Pedro pointed out that Ada couldn't properly handle
> 0xffffffffffffffff. This used to work, but is a regression due to
> some patches I wrote in the Ada lexer. This patch fixes the bug.
Oh, cool, thanks. I believe you need to fix gdb.base/parse_number.exp too, though:
set val "0xffffffffffffffff"
if {$lang == "ada"} {
gdb_test "p/x $val" "Integer literal out of range"
If I'm right, please add a matching ptype like for other languages in that loop.
next prev parent reply other threads:[~2022-04-08 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 19:27 Tom Tromey
2022-04-08 19:31 ` Pedro Alves [this message]
2022-04-12 18:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09061b06-e134-744d-0a34-3c24bb830d66@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).