From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 966C13858D28 for ; Fri, 8 Apr 2022 19:31:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 966C13858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id c7so14431313wrd.0 for ; Fri, 08 Apr 2022 12:31:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=NkPEpumv0js4rEGmEwgIIq+tCF4UsHjRdTiwb138TyU=; b=mUU2Xzd70wf051zxnhhwkM07BzMmZ10psc6OZbS4cqT7KWolJUEMWMApca0C26wq8f QEdqi5XdW/u9SmsPYOgyEt76dJ2NMPaK0sQvAmkyWTvrrC0qKJaGHPc7y7vsgrSpOXV3 MgNI1LMR/4OtT1to+oIN6vFyL1Y0ME0PiJTMW1XY0spfStU7WzdDAWmmhiERy4YF5i6/ 3NOXKmoemYSNSULxWE5aJABzCL3g9m+1akF5uKs6ailoYV7xTOGLY/Mkx1lRS1tPicSL gUbmy626qzeA8eHQI/FS1FXE+6t/K40QeWH2+/LjDnwaoIFC2X1UYR+mkVRuwFGzdD1t it8g== X-Gm-Message-State: AOAM531WUnr5lx6BZXyJqGJXPuXwrblwjoxtV06vNutg7Zl5L7WQc4vT uYiMOTqqhMUwY0ut9qeJWEf0NEVIAXo= X-Google-Smtp-Source: ABdhPJwpy39atE7YlC416bh8nkc6bHkhDPIkgOhFD5oZof7rC/lRmo1wbqIHNJGJaPrYS/tGY90MMw== X-Received: by 2002:a05:6000:1acc:b0:204:2ae7:da14 with SMTP id i12-20020a0560001acc00b002042ae7da14mr15729064wry.609.1649446278430; Fri, 08 Apr 2022 12:31:18 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id u7-20020a5d6da7000000b00203d9d1875bsm23077148wrs.73.2022.04.08.12.31.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Apr 2022 12:31:16 -0700 (PDT) Message-ID: <09061b06-e134-744d-0a34-3c24bb830d66@palves.net> Date: Fri, 8 Apr 2022 20:31:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH + 12.1] Fix bug in Ada number lexing Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20220408192738.2352511-1-tromey@adacore.com> From: Pedro Alves In-Reply-To: <20220408192738.2352511-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 19:31:21 -0000 On 2022-04-08 20:27, Tom Tromey via Gdb-patches wrote: > On irc, Pedro pointed out that Ada couldn't properly handle > 0xffffffffffffffff. This used to work, but is a regression due to > some patches I wrote in the Ada lexer. This patch fixes the bug. Oh, cool, thanks. I believe you need to fix gdb.base/parse_number.exp too, though: set val "0xffffffffffffffff" if {$lang == "ada"} { gdb_test "p/x $val" "Integer literal out of range" If I'm right, please add a matching ptype like for other languages in that loop.