public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH] gdb/linux-nat: xfer_memory_partial return E_IO on error
Date: Thu, 26 May 2022 09:54:21 +0100	[thread overview]
Message-ID: <0920eb6e-1c02-a52a-5180-0c220c73c4db@amd.com> (raw)
In-Reply-To: <216e9d86-dff8-66ad-dd39-fcfd721d12c4@palves.net>



On 25/05/2022 14:35, Pedro Alves wrote:
> [CAUTION: External Email]
> 
> On 2022-05-25 10:29, Lancelot SIX via Gdb-patches wrote:
>> When accessing /proc/PID/mem, if pread64/pwrite64/read/write encounters
>> an error and return -1, linux_proc_xfer_memory_partial return
>> TARGET_XFER_EOF.
>>
>> I think it should return TARGET_XFER_E_IO in this case.  TARGET_XFER_EOF
>> is returned when pread64/pwrite64/read/frite returns 0, which indicates
>> that the address space is gone and the whole process has exited or
>> execed.
>>
>> This patch makes this change.
>>
>> Regression tested on x86_64-linux-gnu.
>>
> 
> OK.

Thanks,

I just pushed this.

Lancelot.

      reply	other threads:[~2022-05-26  8:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-25  9:29 Lancelot SIX
2022-05-25 13:35 ` Pedro Alves
2022-05-26  8:54   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0920eb6e-1c02-a52a-5180-0c220c73c4db@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).