From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 5FE80383E804 for ; Fri, 15 May 2020 14:28:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5FE80383E804 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 34F50AC5B; Fri, 15 May 2020 14:28:03 +0000 (UTC) Subject: Re: [committed][gdb/testsuite] Split up multi-exec test-cases To: Pedro Alves , gdb-patches@sourceware.org References: <20200514152530.GA19399@delia> <456ce125-df9d-6ca7-d08d-9dae83aaed10@redhat.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <09500827-599d-4ef6-eea0-3f74118b530e@suse.de> Date: Fri, 15 May 2020 16:27:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <456ce125-df9d-6ca7-d08d-9dae83aaed10@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-18.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2020 14:28:02 -0000 On 14-05-2020 19:04, Pedro Alves wrote: > On 5/14/20 4:25 PM, Tom de Vries wrote: >> (gdb) spawn gdbserver --once localhost:2592 outputs/gdb.base/align/align^M >> Process outputs/gdb.base/align/align created; pid = 6946^M >> Listening on port 2592^M >> target remote localhost:2592^M >> Remote debugging using localhost:2592^M >> warning: Mismatch between current exec-file outputs/gdb.base/align/c/align^M >> and automatically determined exec-file outputs/gdb.base/align/align^M >> exec-file-mismatch handling is currently "ask"^M >> Load new symbol table from "outputs/gdb.base/align/align"? (y or n) Quit^M >> (gdb) ERROR: test suppressed >> ... > > No objection to the splitting, but the issue above should really be > fixed. > It's a systematic issue, and requiring a file split to address it > seems like a heavy burden to me. Agreed, not all locations where we run into this problem can be fixed/worked-around like that, I just saw an opportunity to trivially reduce test-case complexity with substantial failcount reduction payoff. > Maybe we should disable exec-file-mismatch > detection from within gdb_target_cmd? At least, until we have buildid detection. > But that won't work on all hosts, either. Like, this fixes align.exp for me: > > diff --git c/gdb/testsuite/lib/gdbserver-support.exp w/gdb/testsuite/lib/gdbserver-support.exp > index a2cc80f28d7..fc79f1d60c6 100644 > --- c/gdb/testsuite/lib/gdbserver-support.exp > +++ w/gdb/testsuite/lib/gdbserver-support.exp > @@ -52,7 +52,7 @@ proc gdb_target_cmd_ext { targetname serialport {additional_text ""} } { > > set serialport_re [string_to_regexp $serialport] > for {set i 1} {$i <= 3} {incr i} { > - send_gdb "target $targetname $serialport\n" > + send_gdb "with exec-file-mismatch off -- target $targetname $serialport\n" > gdb_expect 60 { > -re "A program is being debugged already.*ill it.*y or n. $" { > send_gdb "y\n" > That's neat, I tried myself this: ... diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp index a2cc80f28d..66c9bf8549 100644 --- a/gdb/testsuite/lib/gdbserver-support.exp +++ b/gdb/testsuite/lib/gdbserver-support.exp @@ -58,6 +58,11 @@ proc gdb_target_cmd_ext { targetname serialport {additional_text ""} } { send_gdb "y\n" exp_continue } + -re "Load new symbol table from \[^\r\n\]*\\? \\(y or n\\) $" { + send_gdb "y\n" + gdb_test "" "" + return 0 + } -re "unknown host.*$gdb_prompt" { verbose "Couldn't look up $serialport" } ... but I think your solution is better. Thanks, - Tom