From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id EE29B3858D33 for ; Wed, 13 Jan 2021 06:06:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EE29B3858D33 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10D66N39002652 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jan 2021 01:06:27 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10D66N39002652 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2821A1EF78; Wed, 13 Jan 2021 01:06:23 -0500 (EST) Subject: Re: [PATCH 06/12] Factor out after-stop event handling code from stop_all_threads To: Pedro Alves , gdb-patches@sourceware.org References: <20210113011543.2047449-1-pedro@palves.net> <20210113011543.2047449-7-pedro@palves.net> From: Simon Marchi Message-ID: <0960c963-0dbf-9aee-70d0-d6cd6ffb06c5@polymtl.ca> Date: Wed, 13 Jan 2021 01:06:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113011543.2047449-7-pedro@palves.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 13 Jan 2021 06:06:23 +0000 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 06:06:31 -0000 On 2021-01-12 8:15 p.m., Pedro Alves wrote: > This moves the code handling an event out of wait_one to a separate > function, to be used in another context in a following patch. > > gdb/ChangeLog: > > * infrun.c (handle_one): New function, factored out from ... > (stop_all_threads): ... here. I think this is a good cleanup on its own, that function was starting to get crowded. Since that removes a few indentation levels to the code, it would be nice to un-wrap it a little bit, that would help readability. Could you document the meaning of the return value of handle_one in its top comment? Otherwise, that LGTM. Simon