From: Pedro Alves <pedro@palves.net>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb: refactor make-target-delegates.py's ARGTYPES
Date: Tue, 14 Nov 2023 13:47:45 +0000 [thread overview]
Message-ID: <097545b1-73ae-48ed-a242-f5d888e332c4@palves.net> (raw)
In-Reply-To: <fcd59d8fc507387a2e5023a9e06d16c54a6ed2bc.1699953637.git.tankut.baris.aktemur@intel.com>
Hi Baris,
On 2023-11-14 09:41, Tankut Baris Aktemur wrote:
> Refactor the ARGTYPES regular expression in make-target-delegates.py
> to eliminate '.*' for better control on what is matched. This will be
> helpful in the next patch where we recognize default argument values.
> Also, simplify the "E" match group, for which the optional SYMBOL
> becomes redundant because that case can be matched by the "T" group.
>
> After applying this patch, running './make-target-delegates.py' does not
> change anything in 'target-delegates.c'.
With the tweak to the commit log to not mention default arguments:
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2023-11-14 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:41 [PATCH 1/3] gdb: regenerate target-delegates.c Tankut Baris Aktemur
2023-11-14 9:41 ` [PATCH 2/3] gdb: refactor make-target-delegates.py's ARGTYPES Tankut Baris Aktemur
2023-11-14 13:47 ` Pedro Alves [this message]
2023-11-14 9:41 ` [PATCH 3/3] gdb: handle default argument in make-target-delegates.py Tankut Baris Aktemur
2023-11-14 11:31 ` Pedro Alves
2023-11-14 12:48 ` Aktemur, Tankut Baris
2023-11-14 13:36 ` Pedro Alves
2023-11-14 14:17 ` Tom Tromey
2023-11-16 18:11 ` Aktemur, Tankut Baris
2023-11-17 15:41 ` Tom Tromey
2023-11-14 11:14 ` [PATCH 1/3] gdb: regenerate target-delegates.c Pedro Alves
2023-11-14 14:18 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=097545b1-73ae-48ed-a242-f5d888e332c4@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).