From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26999 invoked by alias); 15 Sep 2011 13:58:19 -0000 Received: (qmail 26990 invoked by uid 22791); 15 Sep 2011 13:58:17 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from ausxipps301.us.dell.com (HELO ausxipps301.us.dell.com) (143.166.148.223) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Sep 2011 13:58:04 +0000 X-Loopcount0: from 10.175.216.250 From: To: , CC: Date: Thu, 15 Sep 2011 14:19:00 -0000 Subject: RE: [PATCH] PR/12691 Add the inferior to Python exited event Message-ID: <09787EF419216C41A903FD14EE5506DD0307EF986F@AUSX7MCPC103.AMER.DELL.COM> References: <83vctdej0n.fsf@gnu.org> <83ty8xebob.fsf@gnu.org> <83obz5ea7z.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00271.txt.bz2 > =A0An integer representing the exit code, if available, which the >> =A0inferior has returned. =A0(The exit code could be unavailable if, for >> =A0example, @value{GDBN} detaches from the inferior.) >> > > right, I've updated the patch, is it fine for you ? The old text is more explicit about what you see if the exit code is not av= ailable. It would be good to keep that -- i.e., the attribute isn't there = if the exit code is not available. The reason for being explicit is that a= different way of handling that situation -- and arguably a more "Pythonic"= one -- is for the attribute to exist in all cases but have the value None = if not applicable. So you might make it: +An integer representing the exit code, if available, which the inferior=20 +has returned. (The exit code could be unavailable if, for example, +@value{GDBN} detaches from the inferior.) If the exit code is +unavailable, the attribute does not exist. paul