From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6B1E83865C2A for ; Wed, 23 Mar 2022 18:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6B1E83865C2A Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-0iyHA58DMKC4S82DsJVOBg-1; Wed, 23 Mar 2022 14:56:57 -0400 X-MC-Unique: 0iyHA58DMKC4S82DsJVOBg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 55604899EC4 for ; Wed, 23 Mar 2022 18:56:57 +0000 (UTC) Received: from [10.2.17.71] (unknown [10.2.17.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E325A40CFD05; Wed, 23 Mar 2022 18:56:56 +0000 (UTC) Message-ID: <098a01ab-6de3-b398-d586-2f4b25260e1f@redhat.com> Date: Wed, 23 Mar 2022 11:56:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] Remove download size from debuginfod progress messages To: Aaron Merey Cc: kevinb@redhat.com, gdb-patches@sourceware.org References: <5ed305d0-3650-a9f9-e128-22f873cd96a0@redhat.com> <20220323180616.29957-1-amerey@redhat.com> From: Keith Seitz In-Reply-To: <20220323180616.29957-1-amerey@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 18:57:00 -0000 On 3/23/22 11:06, Aaron Merey wrote: > On Wed, Mar 23, 2022 at 12:02 PM Keith Seitz wrote: >> On 3/22/22 17:34, Aaron Merey wrote: >> >> However, I would really rather not simply remove all download >> sizes. If we can detect the condition that would print the unhelpful >> "-0.00 MB", then *just* removing the download size for that case (or >> printing "unknown" or something) would be my preferred path. > > I wanted to keep this patch as simple as possible in order to avoid > getting bogged down by details that might be more appropriate for > the patch in-progress that reworks these messages. But I agree that > we should continue to print sizes if they are available. I've added > this to the patch below. I appreciate your patience. I think this is fine, but you will need to wait for a global maintainer to approve. Thanks! Keith