From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <m.weghorn@posteo.de>
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by sourceware.org (Postfix) with ESMTPS id 0152E3893664
 for <gdb-patches@sourceware.org>; Tue, 26 May 2020 06:18:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0152E3893664
Received: from submission (posteo.de [89.146.220.130]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 53FE816005C
 for <gdb-patches@sourceware.org>; Tue, 26 May 2020 08:17:58 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 49WP050RM4z6tmF;
 Tue, 26 May 2020 08:17:56 +0200 (CEST)
Subject: Re: [PATCH v5 1/9] gdb: Move construct_inferior_arguments to
 gdbsupport
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
References: <20200429111638.1327262-1-m.weghorn@posteo.de>
 <20200520162115.713005-1-m.weghorn@posteo.de>
 <cf5886ff-7044-9319-3edd-97ce320f6ac7@simark.ca>
From: Michael Weghorn <m.weghorn@posteo.de>
Message-ID: <09d143d7-f003-ee72-7922-7102772b4f08@posteo.de>
Date: Tue, 26 May 2020 08:17:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <cf5886ff-7044-9319-3edd-97ce320f6ac7@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2020 06:18:03 -0000

On 25/05/2020 17.42, Simon Marchi wrote:
> On 2020-05-20 12:21 p.m., Michael Weghorn via Gdb-patches wrote:
>> This moves the function construct_inferior_arguments from
>> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}.
>> While at it, also move the function's comment to the header file
>> to align with current standards.
>>
>> The intention is to use it from gdbserver in a follow-up commit.
>>
>> gdb/ChangeLog:
>>
>> 2020-05-13  Michael Weghorn  <m.weghorn@posteo.de>
>>
>>         * infcmd.c, inferior.h: (construct_inferior_arguments):
>>           Moved function from here to gdbsupport/common-inferior.{h,cc}
>>
>> gdbsupport/ChangeLog:
>>
>> w020-05-13  Michael Weghorn  <m.weghorn@posteo.de>
>>
>>         * common-inferior.h, common-inferior.cc: (construct_inferior_arguments):
>>         Move function here from gdb/infcmd.c, gdb/inferior.h
> 
> I've pushed the whole series, we can take a look at improving how inferior arguments
> are passed to gdb_run_cmd as a separate change.
> 
> Thanks a lot for your contribution and perseverance!
> 
> Simon


Thanks for pushing and all help along the process!

Michael