From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 659DE3857C5F for ; Wed, 26 Jan 2022 20:23:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 659DE3857C5F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-74-qiDkGFk3PvWBeBD803iRUg-1; Wed, 26 Jan 2022 15:23:25 -0500 X-MC-Unique: qiDkGFk3PvWBeBD803iRUg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA63F2F44; Wed, 26 Jan 2022 20:23:24 +0000 (UTC) Received: from [10.2.16.133] (unknown [10.2.16.133]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F04BE4EE1D; Wed, 26 Jan 2022 20:23:23 +0000 (UTC) Message-ID: <09df32bd-fd77-0aa7-01ab-7477c4ee40ed@redhat.com> Date: Wed, 26 Jan 2022 12:23:22 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] gdb: work around negative DW_AT_data_member_location GCC 11 bug To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20211129153725.1499053-1-simon.marchi@efficios.com> <844ce501-7a0d-2806-2a57-d08c71e8bcb4@polymtl.ca> <53f71b5f-a989-7eef-0178-9a96a414ece8@redhat.com> From: Keith Seitz In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 20:23:32 -0000 On 1/26/22 11:18, Simon Marchi wrote: > > if (offset == -1) > { > complaint (_("DW_AT_data_member_location value of -1, assuming 0")); > offset = 0; > } Perfect! > No problem, I'm all for consistency. > > Would you like to list those rules here? > > https://sourceware.org/gdb/wiki/Internals%20GDB-Testsuite-Coding-Standards > > It's always good to have something to refer to. I'll add that to my TODO list. Thanks for the suggestion. There's also the "Cookbook" article. I'll make sure to update that. [Likely with a link to the above coding standard doc, which is unmentioned AFAICT] The template.exp looks fine, so we're set there, I think. Thanks! Keith