From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 434183858C42 for ; Thu, 25 Apr 2024 20:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 434183858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 434183858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714077972; cv=none; b=b8Dncfhk1Vo2cNTajDexV22iiU5XUOaDtf3UxJeuFSKZ7bVqmY9YK9xYdRDdKZfA4oZQRsuYDvz17n3gQ0C3G66C63IHkZWZx9v5Z1VJE4ZiPWt4ICc70PHYLfnxE+Ilg5xb+zrYW57zEOgtGNBynq//ImvVlNDxKDl5DV0VVBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714077972; c=relaxed/simple; bh=0XWkOypU8FdObJdajC+UAtMR7jdwoIPRKhIKkSSmEGc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=qpsHa05sMeWS2hRQhIDkCuFIc9VzlHAahTelY93bMDlVBk+rknLcnLlJ53egsdAZTs4e+nmBn7wFxRRv8QFE9dDp9YsVj+e5K5jt25D1Rx0Yy7QnVVQj26QnXl7aWR3LYB+ZZkI2I8rscPItJq6TlssTeWRw8lasfGWAt6dp+w0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 55EE95C699; Thu, 25 Apr 2024 20:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714077969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DmuDkysrWmRqan0YIRKwYI0wpFzEL7yHKRLumGKm+nw=; b=V0H1MJFEj1EEuZ6Eu2IACMCA0be5aFj86Z0Ro5lz+3m0FDjRrqiFJtNqSwNWyA5M4rXzlc 4vWgSnO8y2VOwni4IFOyI4s2vQk4v09wulPqgzuNeAbHlwi7zYdkEnRP9vKi9NdsyAXxfP T+bkZUrXWGUpculckeQwP++WxylIOqY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714077969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DmuDkysrWmRqan0YIRKwYI0wpFzEL7yHKRLumGKm+nw=; b=sWPPr+ksqt0Bkum268ZCUoN2QQEAFMVkBpiO51Vx7gagudtlnA5hmm94wemt1/ARRmeMZ1 MBTx8Wc3hsORxCBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714077969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DmuDkysrWmRqan0YIRKwYI0wpFzEL7yHKRLumGKm+nw=; b=V0H1MJFEj1EEuZ6Eu2IACMCA0be5aFj86Z0Ro5lz+3m0FDjRrqiFJtNqSwNWyA5M4rXzlc 4vWgSnO8y2VOwni4IFOyI4s2vQk4v09wulPqgzuNeAbHlwi7zYdkEnRP9vKi9NdsyAXxfP T+bkZUrXWGUpculckeQwP++WxylIOqY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714077969; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DmuDkysrWmRqan0YIRKwYI0wpFzEL7yHKRLumGKm+nw=; b=sWPPr+ksqt0Bkum268ZCUoN2QQEAFMVkBpiO51Vx7gagudtlnA5hmm94wemt1/ARRmeMZ1 MBTx8Wc3hsORxCBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 099B913991; Thu, 25 Apr 2024 20:46:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Dey/ABHBKmaTYgAAD6G6ig (envelope-from ); Thu, 25 Apr 2024 20:46:09 +0000 Message-ID: <09f64a9e-b36d-42e8-9ae8-4af3db20eccf@suse.de> Date: Thu, 25 Apr 2024 22:46:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] [gdb/testsuite] Fix end_sequence addresses To: Carl Love , gdb-patches@sourceware.org References: <20240408120445.12544-1-tdevries@suse.de> <20240408120445.12544-3-tdevries@suse.de> <7d515dd6-f327-4587-89c6-ed7e93b7efdd@linux.ibm.com> <8032f800-235f-4181-a84e-2f2fb2a086b7@linux.ibm.com> <64b0e2d7-666d-4435-929e-07fcf3bd9cdb@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.29 X-Spam-Level: X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_ASCII_DIVIDERS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/25/24 19:05, Carl Love wrote: > Tom: > > Thanks for verifying the patch on X86. I agree, including the entire commit message from your patch > is a little overkill. I cut down your commit message and made the description of my fix a little better. > Here is what I now have for the commit message: > > ------------------------------------------------------ > Fix end_sequence addresses for dw2-lines.exp > > The patch: > > From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001 > From: Tom de Vries > Date: Wed, 17 Apr 2024 12:55:00 +0200 > Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses > > I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main: > ... > 00000000004102c4 : > 4102c4: 52800000 mov w0, #0x0 // #0 > 4102c8: 9100c3ff add sp, sp, #0x30 > 4102cc: d65f03c0 ret > ... > is not described by the line table: > ... > > > > > The regression failure on PowerPC is due to the change in file > dw2-lines.exp, > > - DW_LNE_set_address bar_label_5 > + DW_LNE_set_address "$main_start + $main_len" > > The label bar_label_5 is in function bar, not function main. The new > set address should have been $bar_start + $bar_len. > > -------------------------------------------------------- > > Please let me know if that looks reasonable and I will then commit the fix. Thanks! Hi Carl, yes, this is fine, thanks. - Tom > > Carl > > > On 4/24/24 14:07, Tom de Vries wrote: >> On 4/24/24 20:28, Carl Love wrote: >>> >>> Tom: >>> >>> The following patch fixes the issue for me on PowerPC.  Please let me know if it looks ok and if the patch works on your systems as well.  Thanks. >>> >>>                          Carl >> >> Hi Carl, >> >> I don't see the FAILs you mentioned, but your patch is correct, and doesn't regress the test-case for me on x86_64-linux. >> >> Thanks for finding, reporting and fixing this. >> >> So, approved, but consider making the commit message shorter. Including the entire commit message of the patch you're fixing is a bit of an overkill. >> >> Approved-By: Tom de Vries >> >> Thanks, >> - Tom >> >>> >>> ---------------------------------------------------------------------- >>> >>> Fix end_sequence addresses for dw2-lines.exp >>> >>> The patch: >>> >>>    From f0d556d14b1d1c3f8e2f9c13b08adca22e1b8c9c Mon Sep 17 00:00:00 2001 >>>    From: Tom de Vries >>>    Date: Wed, 17 Apr 2024 12:55:00 +0200 >>>    Subject: [PATCH] [gdb/testsuite] Fix end_sequence addresses >>> >>>    I noticed in test-case gdb.reverse/map-to-same-line.exp, that the end of main: >>>    ... >>>    00000000004102c4 : >>>      4102c4:       52800000        mov     w0, #0x0                        // #0 >>>     4102c8:       9100c3ff        add     sp, sp, #0x30 >>>      4102cc:       d65f03c0        ret >>>    ... >>>    is not described by the line table: >>>    ... >>>    File name                    Line number    Starting address    View    Stmt >>>      ... >>>    map-to-same-line.c                    54            0x4102ac               x >>>    map-to-same-line.c                     -            0x4102c4 >>>    ... >>> >>>    Fix this by ending the line table at $main_end. >>> >>>    Likewise in a few other test-cases, found using: >>>    ... >>>    $ find gdb/testsuite/ -type f \ >>>      | xargs grep -B1 DW_LNE_end_sequence \ >>>      | grep set_address \ >>>      | egrep -v "_end|_len" >>>    ... >>> >>>    Tested on aarch64-linux. >>>    --- >>>     gdb/testsuite/gdb.dwarf2/dw2-gas-workaround.exp         | 2 +- >>>     gdb/testsuite/gdb.dwarf2/dw2-inline-header-1.exp        | 2 +- >>>     gdb/testsuite/gdb.dwarf2/dw2-inline-header-2.exp        | 2 +- >>>     gdb/testsuite/gdb.dwarf2/dw2-inline-header-3.exp        | 2 +- >>>     gdb/testsuite/gdb.dwarf2/dw2-line-number-zero.exp       | 7 +++++-- >>>     gdb/testsuite/gdb.dwarf2/dw2-lines.exp                  | 2 +- >>>     gdb/testsuite/gdb.dwarf2/dw2-vendor-extended-opcode.exp | 4 +++- >>>     gdb/testsuite/gdb.dwarf2/imported-unit-bp.exp.tcl       | 2 +- >>>     gdb/testsuite/gdb.reverse/map-to-same-line.c            | 1 - >>>     gdb/testsuite/gdb.reverse/map-to-same-line.exp          | 3 ++- >>>     10 files changed, 16 insertions(+), 11 deletions(-) >>> >>> The issue in file dw2-lines.exp is the change >>> >>> >>> -               DW_LNE_set_address bar_label_5 >>> +               DW_LNE_set_address "$main_start + $main_len" >>> >>> The label bar_label_5 is in function bar, not function  main.  The new >>> set address should have been $bar_start + $bar_len. >>> --- >>>   gdb/testsuite/gdb.dwarf2/dw2-lines.exp | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp >>> index 85d5e9c8afb..af5b6b71768 100644 >>> --- a/gdb/testsuite/gdb.dwarf2/dw2-lines.exp >>> +++ b/gdb/testsuite/gdb.dwarf2/dw2-lines.exp >>> @@ -104,7 +104,7 @@ proc test_1 { _cv _cdw64 _lv _ldw64 {_string_form ""}} { >>>           line [line_for bar_label_4] >>>           DW_LNS_copy >>>   -        DW_LNE_set_address "$main_start + $main_len" >>> +        DW_LNE_set_address "$bar_start + $bar_len" >>>           DW_LNE_end_sequence >>>           } >>>       } >>