From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5616B3858438 for ; Fri, 17 Mar 2023 02:45:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5616B3858438 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 702EC1E110; Thu, 16 Mar 2023 22:45:18 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1679021118; bh=5qFLDnJZwBBO4x2UBbidhl0erwaf01OJn8lrD6WaCxM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=nNphuFuI6nTW+VvhvFNc3i/zWR7lZWsdilYs3tr076YpVQYrvEqrxFxZ1XQNLYXQg hwynQI82OrfvpjXV5mQzyV0eWvR0/ULZDrw61mK2L9vZ9zWYNGRYoXJBG6+tCHdDj4 z758PtOSdyugED1Y0/4IKd+yaEpokzCw5lmZ4NAk= Message-ID: <0a02e351-0b13-c3b0-f324-b8e71ea44a7b@simark.ca> Date: Thu, 16 Mar 2023 22:45:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/5] Change linetables to be objfile-independent Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches References: <20230308-submit-constify-linetable-v1-0-ca4057478141@tromey.com> <20230308-submit-constify-linetable-v1-2-ca4057478141@tromey.com> <87jzzne1vo.fsf@tromey.com> <87fsaaejnb.fsf@tromey.com> <87y1nwiyk2.fsf@tromey.com> <7ef34f41-d90a-8173-b0b8-08a19b0b4484@simark.ca> <87bkkscled.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87bkkscled.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/16/23 19:43, Tom Tromey wrote: > Simon> I can reproduce it like hand like this: > [...] > > I think I have a fix for it. I'll send it tomorrow. > > Tom Ok, I worked on that today and also have some patches. One fixes do_mixed_source_and_assembly, and the other makes "maint info line-table" show relocated addresses again, it fixes a test that relied on that (I guess we could also change the test). If you want to take a peek: https://review.lttng.org/c/binutils-gdb/+/9665 Simon