From: Simon Marchi <simark@simark.ca>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 1/2] guile: Add support for Guile 2.2.
Date: Sun, 19 Jul 2020 11:45:03 -0400 [thread overview]
Message-ID: <0a54056e-c491-6e87-5ad3-4f652f92383f@simark.ca> (raw)
In-Reply-To: <20200718190038.GA582@adacore.com>
On 2020-07-18 3:00 p.m., Joel Brobecker wrote:
> Hi Simon,
>
>>> This primarily updates code that uses the I/O port API of Guile.
>>
>> I know nothing about Guile, so I just scanned the patch for any obvious
>> red flags, but didn't see any. The mess of #if statements sure is not
>> the best, but I don't have a concrete suggestion to make it better.
>
> I'm not confident that we'll be able to find a reviewer who has
> more experience with this part of the Code. What do you think of
> approving this patch series based on your review?
Yeah, I think we can go ahead. Ludovic, do you have push access or would you like me to push it?
Simon
next prev parent reply other threads:[~2020-07-19 15:45 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 13:27 [PATCH 0/2] Add support for Guile 3.0 and 2.2 Ludovic Courtès
2020-06-12 13:27 ` [PATCH 1/2] guile: Add support for Guile 2.2 Ludovic Courtès
2020-06-12 13:50 ` Eli Zaretskii
2020-06-12 14:04 ` Ludovic Courtès
2020-06-13 6:44 ` Eli Zaretskii
2020-06-13 15:04 ` Ludovic Courtès
2020-06-15 15:14 ` [PATCH v2 0/2] Add support for Guile 3.0 and 2.2 Ludovic Courtès
2020-06-15 15:14 ` [PATCH v2 1/2] guile: Add support for Guile 2.2 Ludovic Courtès
2020-06-15 17:00 ` Eli Zaretskii
2020-06-18 20:31 ` Tom Tromey
2020-06-19 6:08 ` Eli Zaretskii
2020-06-19 7:37 ` Ludovic Courtès
2020-06-26 8:13 ` [PATCH v3 0/2] Add support for Guile 3.0 and 2.2 Ludovic Courtès
2020-06-26 8:13 ` [PATCH v3 1/2] guile: Add support for Guile 2.2 Ludovic Courtès
2020-06-26 10:23 ` Eli Zaretskii
2020-06-28 14:20 ` Ludovic Courtès
2020-06-28 14:25 ` [PATCH v4 " Ludovic Courtès
2020-06-28 16:40 ` Eli Zaretskii
2020-07-03 0:31 ` Simon Marchi
2020-07-03 7:06 ` Ludovic Courtès
2020-07-18 19:00 ` Joel Brobecker
2020-07-19 15:45 ` Simon Marchi [this message]
2020-07-20 8:05 ` Ludovic Courtès
2020-07-20 15:01 ` Simon Marchi
2020-07-21 21:10 ` Ludovic Courtès
2020-06-28 14:25 ` [PATCH v4 2/2] guile: Add support for Guile 3.0 Ludovic Courtès
2020-06-28 16:38 ` [PATCH v3 1/2] guile: Add support for Guile 2.2 Eli Zaretskii
2020-06-28 16:51 ` Ludovic Courtès
2020-07-02 12:57 ` [PING] Add support for Guile 2.2/3.0 Ludovic Courtès
2020-07-13 15:36 ` Tom Tromey
2020-06-26 8:13 ` [PATCH v3 2/2] guile: Add support for Guile 3.0 Ludovic Courtès
2020-06-26 10:13 ` Eli Zaretskii
2020-06-15 15:14 ` [PATCH v2 " Ludovic Courtès
2020-06-12 14:14 ` [PATCH 1/2] guile: Add support for Guile 2.2 Tom de Vries
2020-06-12 14:36 ` Ludovic Courtès
2020-06-12 13:27 ` [PATCH 2/2] guile: Add support for Guile 3.0 Ludovic Courtès
2020-06-15 15:02 ` Tom Tromey
2020-06-15 15:17 ` Ludovic Courtès
2020-06-17 16:58 ` Ludovic Courtès
2020-06-17 17:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a54056e-c491-6e87-5ad3-4f652f92383f@simark.ca \
--to=simark@simark.ca \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).