From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 854BB3858D20 for ; Thu, 3 Mar 2022 18:57:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 854BB3858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id u10so7637843wra.9 for ; Thu, 03 Mar 2022 10:57:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=xzHFnmDiCad8l7ML2FNBxsKmPteKJnU9CWLoPrNTzww=; b=UA/fhUPXo6fYxE8KGHSFfNVerGYklWHEjrUv25hYS9RFzvW1LZLpZsRyssOWNPd/WD C4mB69xlkFMHjE6V4s3DmBXWV53WHV4J5m+YLvbbbiHJgPn6ADFphKoYPXMSanCSCjbb aG3RQXHiNwxmhhwor5u/x4MDh1srAH7+4MXGyRPLIcSzdpK3MBEeXx+dfzmoig7ejCJM 6HwDsk0tZy1zS44EV0yJLewzaaDo4lEB6jwEGlyJCqEeg/ATwJLW+Y8ylsTOe99b4Xf5 QNEDip4HY+g76M4wxy2PX0NAYNZfTd9sG3U3A8j4w8mtmz3ggQduwuvUep5rLjimT7OQ OxHw== X-Gm-Message-State: AOAM5306sjZ69x7bhZfwQUOKrg51Q/i2JCNTDJ+W+wczPC7KJxSO2FYv piHAakzBsuw8LX8KsuTH4Mbs5tasdyQ= X-Google-Smtp-Source: ABdhPJxXIB9Wagxy49mXZrbWj1kPPCt9/bb8X/pL84eu7k0gLIZ7YJNlKEmj0iO63M6Ij+CMcSjZyA== X-Received: by 2002:a5d:6d4c:0:b0:1e6:335f:6b65 with SMTP id k12-20020a5d6d4c000000b001e6335f6b65mr28705946wri.371.1646333845391; Thu, 03 Mar 2022 10:57:25 -0800 (PST) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id r15-20020a05600c35cf00b003808165fbc2sm3274626wmq.25.2022.03.03.10.57.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 10:57:24 -0800 (PST) Message-ID: <0a65b1a3-5d1d-eb09-e280-cccb1b27f42a@palves.net> Date: Thu, 3 Mar 2022 18:57:23 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH users/roland/event-pipe] Avoid conflict with gnulib open/close macros. Content-Language: en-US To: Roland McGrath , GDB References: From: Pedro Alves In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2022 18:57:28 -0000 On 2022-03-02 00:26, Roland McGrath via Gdb-patches wrote: > [This patch is on sourceware branch users/roland/event-pipe for your > convenience. I can merge it in myself after approval.] > > On some systems, the gnulib configuration will decide to define open > and/or close as macros to replace the POSIX C functions. This > interferes with using those names in C++ class or namespace scopes. > > gdbsupport/ > * event-pipe.cc (event_pipe::open): Renamed to ... > (event_pipe::open_pipe): ... this. > (event_pipe::close): Renamed to ... > (event_pipe::close_pipe): ... this. > * event-pipe.h (class event_pipe): Updated. > gdb/ > * inf-ptrace.h (async_file_open, async_file_close): Updated. > gdbserver/ > * gdbserver/linux-low.cc (linux_process_target::async): Likewise. OK, thanks.