From: Pedro Alves <palves@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] infrun: step through indirect branch thunks
Date: Mon, 09 Apr 2018 16:29:00 -0000 [thread overview]
Message-ID: <0a6901c7-e26e-0c35-12d0-60f1da08a1aa@redhat.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2369669720@IRSMSX103.ger.corp.intel.com>
On 04/09/2018 05:24 PM, Metzger, Markus T wrote:
> It is not the default. I had to add a new function to return the default. IIUC this
> is disabling INVALID_P checks to allow default_in_indirect_branch_thunk to be
> used as default.
Ah, yeah.
>
>
>>> + gdb_test_multiple "stepi" "$test: stepi" {
>>> + -re "$current.*$gdb_prompt $" {
>>> + send_gdb "stepi\n"
>>> + exp_continue
>>
>> This should probably have some upper bound.
>
> Unless some compiler bug generated an infinite loop or GDB's stepping is
> completely broken, we should eventually step out of $current.
If nothing would ever break, we wouldn't need regression tests. :-)
Keep developers doing local changes and breaking things routinely in
mind as well.
> I read your comment about an upper bound in your first reply but thought
> that it wouldn't be necessary. Do you think we need one?
I do, because if for some reason the end up in the infinite loop, the
testcase will never timeout, hanging the test run.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-04-09 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 5:16 Markus Metzger
2018-03-26 17:38 ` Pedro Alves
2018-04-09 14:20 ` Metzger, Markus T
2018-04-09 14:42 ` [pushed/ob] Apply "Convert observers to C++" edit to gdbarch.sh (Re: [PATCH] infrun: step through indirect branch thunks) Pedro Alves
2018-04-09 15:04 ` [PATCH] infrun: step through indirect branch thunks Pedro Alves
2018-04-09 16:24 ` Metzger, Markus T
2018-04-09 16:29 ` Pedro Alves [this message]
2018-04-10 9:02 ` Metzger, Markus T
2018-04-10 9:10 ` Pedro Alves
2018-04-13 14:58 ` Gary Benson
2018-04-13 16:07 ` Simon Marchi
2018-04-15 19:47 ` Simon Marchi
2018-04-16 6:51 ` Metzger, Markus T
2018-04-17 13:32 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a6901c7-e26e-0c35-12d0-60f1da08a1aa@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).