From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94777 invoked by alias); 9 Apr 2018 16:29:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94754 invoked by uid 89); 9 Apr 2018 16:29:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Apr 2018 16:29:44 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06AFC406E96B; Mon, 9 Apr 2018 16:29:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73F0A2166BAE; Mon, 9 Apr 2018 16:29:42 +0000 (UTC) Subject: Re: [PATCH] infrun: step through indirect branch thunks To: "Metzger, Markus T" , "gdb-patches@sourceware.org" References: <1519017382-24335-1-git-send-email-markus.t.metzger@intel.com> <4dfab882-016f-01b5-bb28-67cd6637acea@redhat.com> From: Pedro Alves Message-ID: <0a6901c7-e26e-0c35-12d0-60f1da08a1aa@redhat.com> Date: Mon, 09 Apr 2018 16:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00152.txt.bz2 On 04/09/2018 05:24 PM, Metzger, Markus T wrote: > It is not the default. I had to add a new function to return the default. IIUC this > is disabling INVALID_P checks to allow default_in_indirect_branch_thunk to be > used as default. Ah, yeah. > > >>> + gdb_test_multiple "stepi" "$test: stepi" { >>> + -re "$current.*$gdb_prompt $" { >>> + send_gdb "stepi\n" >>> + exp_continue >> >> This should probably have some upper bound. > > Unless some compiler bug generated an infinite loop or GDB's stepping is > completely broken, we should eventually step out of $current. If nothing would ever break, we wouldn't need regression tests. :-) Keep developers doing local changes and breaking things routinely in mind as well. > I read your comment about an upper bound in your first reply but thought > that it wouldn't be necessary. Do you think we need one? I do, because if for some reason the end up in the infinite loop, the testcase will never timeout, hanging the test run. Thanks, Pedro Alves