From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 214DF3858C52 for ; Thu, 2 Feb 2023 20:56:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 214DF3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 592C91E110; Thu, 2 Feb 2023 15:56:36 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675371396; bh=JraK/+7oJJKnIZWE6BayhDNVNUHteDbNhwA1pCmJlro=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aMskEEPbsJRAMleorQw9VBi6VIhFNnV8quYxUUdNQ9TkSVMXrmKndcoUZ7Thy7nQs OOsxPk4d3JNT+dtAJHsY4NChnkko+FSRxen/6CBrA5cFiBudZPgZUvMI36bVADNwK1 zIF9r5EvFft9Vfp3mp8xOr/wFEsRJLi2+Hz4d1GM= Message-ID: <0a699595-7fbf-827e-9658-63a27def846d@simark.ca> Date: Thu, 2 Feb 2023 15:56:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 5/8] gdbserver: Transmit target description ID in thread list and stop reply Content-Language: en-US To: Thiago Jung Bauermann Cc: Andrew Burgess , Thiago Jung Bauermann via Gdb-patches , Simon Marchi References: <20230130044518.3322695-1-thiago.bauermann@linaro.org> <20230130044518.3322695-6-thiago.bauermann@linaro.org> <87lelhtwqv.fsf@redhat.com> <87mt5vajoz.fsf@linaro.org> From: Simon Marchi In-Reply-To: <87mt5vajoz.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I agree it makes more sense to use hex everywhere. > > In the case of XML attribute fields, enforcing hex would mean adding a > base parameter to xml_parse_unsigned_integer (which currently accepts > decimal, octal and hex). I'll do that. > > In the case of the core field, to avoid breaking existing stubs it's > probably better to document that it can accept any of the three bases. The "core" field is parsed using gdb_xml_parse_attr_ulongest, which uses strtoulst with a base of 0. So I suppose that an hex value with the 0x prefix would work. So bases other than 10 can work, but they need to have the appropriate prefix. Simon