From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb] Avoid warnings in cooked_{read,write}_test for m68hc11
Date: Mon, 13 Jun 2022 17:20:54 +0200 [thread overview]
Message-ID: <0a72be99-01a1-79af-a807-b02028a00734@suse.de> (raw)
In-Reply-To: <20220607080158.GA11931@delia.home>
On 6/7/22 10:02, Tom de Vries via Gdb-patches wrote:
> Hi,
>
> With --enable-targets=all we have:
> ...
> $ gdb -q -batch -ex "maint selftest"
> ...
> Running selftest regcache::cooked_read_test::m68hc11.
> warning: No frame soft register found in the symbol table.
> Stack backtrace will not work.
> Running selftest regcache::cooked_read_test::m68hc12.
> warning: No frame soft register found in the symbol table.
> Stack backtrace will not work.
> Running selftest regcache::cooked_read_test::m68hc12:HCS12.
> warning: No frame soft register found in the symbol table.
> Stack backtrace will not work.
> ...
>
> Likewise for regcache::cooked_write_test.
>
> The warning has no use in the selftest context.
>
> Fix this by skipping the specific selftests.
>
> Tested on x86_64-linux.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29224
>
> Any comments?
>
Committed.
Thanks,
- Tom
> [gdb] Avoid warnings in cooked_{read,write}_test for m68hc11
>
> ---
> gdb/regcache.c | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gdb/regcache.c b/gdb/regcache.c
> index 037659ef8fa..6fd4f86f4bf 100644
> --- a/gdb/regcache.c
> +++ b/gdb/regcache.c
> @@ -1812,12 +1812,34 @@ class readwrite_regcache : public regcache
> {}
> };
>
> +/* Return true if regcache::cooked_{read,write}_test should be skipped for
> + GDBARCH. */
> +
> +static bool
> +selftest_skiparch (struct gdbarch *gdbarch)
> +{
> + const char *name = gdbarch_bfd_arch_info (gdbarch)->printable_name;
> +
> + /* Avoid warning:
> + Running selftest regcache::cooked_{read,write}_test::m68hc11.
> + warning: No frame soft register found in the symbol table.
> + Stack backtrace will not work.
> + We could instead capture the output and then filter out the warning, but
> + that seems more trouble than it's worth. */
> + return (strcmp (name, "m68hc11") == 0
> + || strcmp (name, "m68hc12") == 0
> + || strcmp (name, "m68hc12:HCS12") == 0);
> +}
> +
> /* Test regcache::cooked_read gets registers from raw registers and
> memory instead of target to_{fetch,store}_registers. */
>
> static void
> cooked_read_test (struct gdbarch *gdbarch)
> {
> + if (selftest_skiparch (gdbarch))
> + return;
> +
> scoped_mock_context<target_ops_no_register> mockctx (gdbarch);
>
> /* Test that read one raw register from regcache_no_target will go
> @@ -1944,6 +1966,9 @@ cooked_read_test (struct gdbarch *gdbarch)
> static void
> cooked_write_test (struct gdbarch *gdbarch)
> {
> + if (selftest_skiparch (gdbarch))
> + return;
> +
> /* Create a mock environment. A process_stratum target pushed. */
> scoped_mock_context<target_ops_no_register> ctx (gdbarch);
> readwrite_regcache readwrite (&ctx.mock_target, gdbarch);
prev parent reply other threads:[~2022-06-13 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 8:02 [PATCH][gdb] " Tom de Vries
2022-06-13 15:20 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a72be99-01a1-79af-a807-b02028a00734@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).