Re: [PATCH 1/4] gdb: add type::is_declared_class / type::set_is_declared_class

[Simon Marchi <simon.marchi@efficios.com>]

On 2021-04-01 2:04 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> Add the `is_declared_class` and `set_is_declared_class` methods on
> Simon> `struct type`, in order to remove the `TYPE_DECLARED_CLASS` macro.  In
> Simon> this patch, the macro is changed to use the getter, so all the call
> Simon> sites of the macro that are used as a setter are changed to use the
> Simon> setter method directly.  The next patch will remove the macro
> Simon> completely.
> 
> Simon> gdb/ChangeLog:
> 
> Simon> 	* gdbtypes.h (struct type) <is_declared_class,
> set_is_declared_class> : New methods.
> Simon> 	(TYPE_DECLARED_CLASS): Use type::is_declared_class, change all
> Simon> 	write call sites to use type::set_is_declared_class.
> 
> I skimmed through this series and all four of these look reasonable to me.
> Thank you.
> 
> Tom
> 

Thanks, pushed.

Simon