From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id E13983858CD1 for ; Wed, 20 Mar 2024 10:27:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E13983858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E13983858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710930435; cv=none; b=hPxbFcq4I29bJVjjVnatpIOTNA4u+ijJm04Eek3G03HE0a7TQgKxTrQ4LSRH34J0PGTvQfTSzTKf9lLtuLYDjF2RFaLA68Jx9LkmBW7jMup0sNcjzslVXMIcdjxJ6T9vWPExpuGpWZjujS1Q0zGUsG4TggFBbSmdX9jgNvOwo+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710930435; c=relaxed/simple; bh=Q0eHYlsJJojV3cePPcGVCR2+mDopC1xroSyAHmEqLBU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=oCSOKmT+mpDMItTpI94C3F5rRWCbWvmkpl+7J/woe8HESLL+1a4JK1zSXvYjYsciWvSbFpwOb4A9xgfvEzr7miyAPqHN3sv9o9Gl7I0kjTVmoN7yA1JDXXlPivgydhuO7Q4fKKBIfHjuXsDhuokZYpFAp+TyTZ/iMPayg3WYRUU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A15F520CB3; Wed, 20 Mar 2024 10:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710930431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOWmcNkSZVP3lzKrJFZoveMv7PCB5Lw/gh1D8TjDOMc=; b=0FesHKIW2ApX7fdZpCTdoP4dOeBzWe3qjZAndChK60f/IHxFBGMPWTj2PvVn+DxGk3ObxS 0JrTqbEYHlz+AbpWXI5UAJjY4jNQ2ot/NtESZ2TPHB4/ejhSXGzNmzE5CQVZGwfINWdA0u yRqVF0Jrk+RaHtrByxdL/rBpk1/478g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710930431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOWmcNkSZVP3lzKrJFZoveMv7PCB5Lw/gh1D8TjDOMc=; b=RzOO6Q7Z6d/VVxrYkmKcqI9uJODsc3kpWxcmPqhZ+jDYiSgyOB30fYO/V1eURqEfk5Mi8F IbbrW34w81iJPkAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710930430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOWmcNkSZVP3lzKrJFZoveMv7PCB5Lw/gh1D8TjDOMc=; b=PfQP6tjvlXtw3Muw32nTbPkLKeyzjP4b7uQtUXAPOc4BFHbXtSjCGZ2+RalZhkcjKSr/fI s5APrRLYwOLFHyUTXmGv8AhN1p46qCOTsbMz1mNG8GSGCPuU9O/MGnij4MR8zIolWsSFZh 5gSmriqxwJU2ZJtXwFgjL0KbL1dkM0k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710930430; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bOWmcNkSZVP3lzKrJFZoveMv7PCB5Lw/gh1D8TjDOMc=; b=3HAegrXYt6FomZdHMsBQZzWpvv8VR3jFhSOsjPIG3352u62gK87+SDOj9cvZhD0ok5DshT SGfcR52kuTMTfzBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 875FD136D6; Wed, 20 Mar 2024 10:27:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SOiaH/65+mU4agAAD6G6ig (envelope-from ); Wed, 20 Mar 2024 10:27:10 +0000 Message-ID: <0ace9a76-2886-41e6-aa02-ef7c8d87f777@suse.de> Date: Wed, 20 Mar 2024 11:28:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Speed up lookup of "type_specific_data" Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240215160838.3999663-1-tromey@adacore.com> <87frwmglnt.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87frwmglnt.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -2.44 X-Spamd-Result: default: False [-2.44 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.15)[88.75%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/19/24 18:45, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> I noticed that "info locals" on a certain large Ada program was very > Tom> slow. I tracked this down to ada_get_tsd_type expanding nearly every > Tom> CU in the program. > > Tom> This patch fixes the problem by changing this code to use the more > Tom> efficient lookup_transparent_type which, unlike the Ada-specific > Tom> lookup functions, does not try to find all matching instances. > > I'm checking this in. > I'm running into: ... FAIL: gdb.ada/tagged-lookup.exp: only one CU expanded ... Filed here ( https://sourceware.org/bugzilla/show_bug.cgi?id=31514 ). Thanks, - Tom