From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80201 invoked by alias); 17 Oct 2018 21:51:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 80185 invoked by uid 89); 17 Oct 2018 21:51:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Oct 2018 21:51:23 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B5B530C9EE3; Wed, 17 Oct 2018 21:51:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF6DC764E0; Wed, 17 Oct 2018 21:51:20 +0000 (UTC) Subject: Re: [PATCH][gdb] fix unsigned overflow in charset.c To: Paul Koning , John Baldwin References: <7B48D309-445E-4141-A87A-1F3D5FA70EFD@comcast.net> <1acace4a-a5c6-abaf-f070-9c2e6768b6f2@redhat.com> <9ea7a1f6-5c3f-c569-6bba-ca9e21711de1@FreeBSD.org> <2DCE0AB8-5647-4AD1-B0AA-3A8350C3BE6D@comcast.net> <17fcbb42-d694-af87-9a8d-d01addee992b@FreeBSD.org> <42e6b4b2-fb05-25f6-ef0a-73ce854116de@redhat.com> <31fcba01-1f2c-d932-94f2-69b7cb14601a@FreeBSD.org> <15814BE7-1C4F-4067-99A5-A004D094FB96@comcast.net> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <0addc221-09f0-36e0-9bf4-370472a23a53@redhat.com> Date: Wed, 17 Oct 2018 21:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <15814BE7-1C4F-4067-99A5-A004D094FB96@comcast.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00387.txt.bz2 On 10/17/2018 07:47 PM, Paul Koning wrote: > > >> On Oct 17, 2018, at 2:38 PM, John Baldwin wrote: >> >>> ... >>> From an aesthetic perspective, "ssize_t" seems better, as the "obvious >>> signed version of size_t". From a pedantic perspective, ptrdiff_t >>> sounds better. >> >> Ok, I think ssize_t is probably fine, so I Think Paul's original patch is >> ok? >> >> -- >> John Baldwin > > Please let me know; I can commit that patch if it is approved. Or commit with changes if that's desired. Patch is OK as is. Please push. Thanks, Pedro Alves