From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: use -1 for breakpoint::task default value
Date: Wed, 8 Feb 2023 18:10:40 +0000 [thread overview]
Message-ID: <0aec159e-085d-5e4b-636f-c46c287d2ddb@palves.net> (raw)
In-Reply-To: <6ab8502906e90c53dbb2a758f2e02acab05da4ee.1675869267.git.aburgess@redhat.com>
On 2023-02-08 3:16 p.m., Andrew Burgess via Gdb-patches wrote:
> Within the breakpoint struct we have two fields ::thread and ::task
> which are used for thread or task specific breakpoints. When a
> breakpoint doesn't have a specific thread or task then these fields
> have the values -1 and 0 respectively.
>
> There's no particular reason (as far as I can tell) why these two
> "default" values are different, and I find the difference a little
> confusing. Long term I'd like to potentially fold these two fields
> into a single field, but that isn't what this commit does.
>
> What this commit does is switch to using -1 as the "default" value for
> both fields, this means that the default for breakpoint::task has
> changed from 0 to -1. I've updated all the code I can find that
> relied on the value of 0, and I see no test regressions, especially in
> gdb.ada/tasks.exp, which still fully passes.
>
> There should be no user visible changes after this commit.
This bothered me before as well. Thanks for doing this.
Approved-By: Pedro Alves <pedro@palves.net>
next prev parent reply other threads:[~2023-02-08 18:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:16 [PATCH 0/2] Prevent combining 'task' and 'thread' keywords Andrew Burgess
2023-02-08 15:16 ` [PATCH 1/2] gdb: only allow one of thread or task on breakpoints or watchpoints Andrew Burgess
2023-02-08 15:52 ` Eli Zaretskii
2023-02-08 18:10 ` Pedro Alves
2023-02-12 5:50 ` Andrew Burgess
2023-02-12 22:58 ` Tom Tromey
2023-02-13 11:26 ` Andrew Burgess
2023-02-08 15:16 ` [PATCH 2/2] gdb: use -1 for breakpoint::task default value Andrew Burgess
2023-02-08 18:10 ` Pedro Alves [this message]
2023-02-12 7:23 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aec159e-085d-5e4b-636f-c46c287d2ddb@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).