From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 0A03F3858C2D
 for <gdb-patches@sourceware.org>; Fri,  5 Aug 2022 20:03:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A03F3858C2D
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id CA1D91E745;
 Fri,  5 Aug 2022 16:03:04 -0400 (EDT)
Message-ID: <0aff8f76-bfe0-a62e-421b-921aa6d7946e@simark.ca>
Date: Fri, 5 Aug 2022 16:03:04 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 2/2] [gdb/symtab] Fix assert in read_addrmap_from_aranges
Content-Language: en-US
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
References: <20220805114116.8338-1-tdevries@suse.de>
 <20220805114116.8338-2-tdevries@suse.de>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <20220805114116.8338-2-tdevries@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Aug 2022 20:03:08 -0000



> +save_vars { Dwarf::_add_dummy_cus } {
> +
> +    set Dwarf::_add_dummy_cus 0

Could we make that an option to Dwarf::assemble?  Just an idea, turn:

  proc assemble {filename body}

into

  proc assemble {options body}

... where options could be:

  Dwarf::assemble {
    filename $asm_file
    add_dummy_cus 0
  } {
    ... body ...
  }

And if $options is of length one, you transform it into

  {filename $options}

such that existing test cases don't have to be changed.

Simon