From: John Baldwin <jhb@FreeBSD.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>, Kamil Rytarowski <n54@gmx.com>
Subject: Re: [PATCH] Remove use of deprecated core functions (in NetBSD/ARM)
Date: Mon, 9 Mar 2020 13:53:09 -0700 [thread overview]
Message-ID: <0b1c5cbf-58d2-153f-003c-b55e5f6b972f@FreeBSD.org> (raw)
In-Reply-To: <CAPTJ0XFOMHsVb2CNuowXmTcB-SgM65-FO8DURqP-5C4hXUFT6w@mail.gmail.com>
On 3/6/20 2:48 PM, Christian Biesinger via gdb-patches wrote:
> Thanks for the feedback; I thought about that but there are two places
> in this function that make this harder -- there is an arm_apcs_32
> check that affects what gets supplied for ARM_PS_REGNUM and there's a
> call to gdbarch_addr_bits_remove on the PC, perhaps for the thumb bit.
> So I think I cannot convert it while keeping the same semantics?
>
> The fetch_registers implementation does share this code with my patch.
>
> Any thoughts?
Fair enough, that does make it harder to handle as simply. The current patch
is certainly an improvement.
--
John Baldwin
next parent reply other threads:[~2020-03-09 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200306205900.239755-1-cbiesinger@google.com>
[not found] ` <fda20e67-3cdd-89ee-4c3a-7ab334a30793@FreeBSD.org>
[not found] ` <CAPTJ0XFOMHsVb2CNuowXmTcB-SgM65-FO8DURqP-5C4hXUFT6w@mail.gmail.com>
2020-03-09 20:53 ` John Baldwin [this message]
[not found] ` <f732d439-95bc-e427-b1d6-b9fcfaabbd8a@simark.ca>
2020-03-11 20:48 ` Christian Biesinger
2020-03-12 13:44 ` Kamil Rytarowski
2020-03-12 17:23 ` Christian Biesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b1c5cbf-58d2-153f-003c-b55e5f6b972f@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=n54@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).