From: Luis Machado <lgustavo@codesourcery.com>
To: Ambrogino Modigliani <ambrogino.modigliani@gmail.com>,
<gdb-patches@sourceware.org>, <pedro_alves@portugalmail.pt>,
<ambrogino.modigliani@mail.com>
Subject: Re: [PATCH 1/3] Fix spelling in comments in C source files (zlib)
Date: Fri, 25 Nov 2016 21:01:00 -0000 [thread overview]
Message-ID: <0b486af6-76ee-2033-08e1-16a106d5e6ef@codesourcery.com> (raw)
In-Reply-To: <1480103124-9508-2-git-send-email-ambrogino.modigliani@mail.com>
On 11/25/2016 01:45 PM, Ambrogino Modigliani wrote:
> zlib/ChangeLog:
>
> * contrib/minizip/ioapi.h: Fix spelling in comments.
> * contrib/minizip/miniunz.c: Fix spelling in comments.
> * contrib/minizip/minizip.c: Fix spelling in comments.
> * contrib/minizip/unzip.c: Fix spelling in comments.
> * contrib/minizip/unzip.h: Fix spelling in comments.
> * contrib/minizip/zip.c: Fix spelling in comments.
> * examples/enough.c: Fix spelling in comments.
> * examples/zran.c: Fix spelling in comments.
> ---
> zlib/contrib/minizip/ioapi.h | 2 +-
> zlib/contrib/minizip/miniunz.c | 2 +-
> zlib/contrib/minizip/minizip.c | 4 ++--
> zlib/contrib/minizip/unzip.c | 8 ++++----
> zlib/contrib/minizip/unzip.h | 4 ++--
> zlib/contrib/minizip/zip.c | 2 +-
> zlib/examples/enough.c | 2 +-
> zlib/examples/zran.c | 2 +-
> 8 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/zlib/contrib/minizip/ioapi.h b/zlib/contrib/minizip/ioapi.h
> index 8dcbdb0..e19f5c2 100644
> --- a/zlib/contrib/minizip/ioapi.h
> +++ b/zlib/contrib/minizip/ioapi.h
> @@ -82,7 +82,7 @@
> #include "mz64conf.h"
> #endif
>
> -/* a type choosen by DEFINE */
> +/* a type chosen by DEFINE */
> #ifdef HAVE_64BIT_INT_CUSTOM
> typedef 64BIT_INT_CUSTOM_TYPE ZPOS64_T;
> #else
> diff --git a/zlib/contrib/minizip/miniunz.c b/zlib/contrib/minizip/miniunz.c
> index 3d65401b..6ca6858 100644
> --- a/zlib/contrib/minizip/miniunz.c
> +++ b/zlib/contrib/minizip/miniunz.c
> @@ -607,7 +607,7 @@ int main(argc,argv)
> # endif
>
> strncpy(filename_try, zipfilename,MAXFILENAME-1);
> - /* strncpy doesnt append the trailing NULL, of the string is too long. */
> + /* strncpy doesn't append the trailing NULL, of the string is too long. */
"... or the string..."
Multiple occurrences of the same typo...
> filename_try[ MAXFILENAME ] = '\0';
>
> # ifdef USEWIN32IOAPI
> diff --git a/zlib/contrib/minizip/minizip.c b/zlib/contrib/minizip/minizip.c
> index 4288962..b13ca60 100644
> --- a/zlib/contrib/minizip/minizip.c
> +++ b/zlib/contrib/minizip/minizip.c
> @@ -113,7 +113,7 @@ uLong filetime(f, tmzip, dt)
> len = MAXFILENAME;
>
> strncpy(name, f,MAXFILENAME-1);
> - /* strncpy doesnt append the trailing NULL, of the string is too long. */
> + /* strncpy doesn't append the trailing NULL, of the string is too long. */
> name[ MAXFILENAME ] = '\0';
>
...here...
> if (name[len - 1] == '/')
> @@ -322,7 +322,7 @@ int main(argc,argv)
>
> zipok = 1 ;
> strncpy(filename_try, argv[zipfilenamearg],MAXFILENAME-1);
> - /* strncpy doesnt append the trailing NULL, of the string is too long. */
> + /* strncpy doesn't append the trailing NULL, of the string is too long. */
> filename_try[ MAXFILENAME ] = '\0';
... and here.
>
> len=(int)strlen(filename_try);
> diff --git a/zlib/contrib/minizip/unzip.c b/zlib/contrib/minizip/unzip.c
> index 9093504..cbc482c 100644
> --- a/zlib/contrib/minizip/unzip.c
> +++ b/zlib/contrib/minizip/unzip.c
> @@ -53,7 +53,7 @@
> Oct-2009 - Mathias Svensson - Fixed problem if uncompressed size was > 4G and compressed size was <4G
> should only read the compressed/uncompressed size from the Zip64 format if
> the size from normal header was 0xFFFFFFFF
> - Oct-2009 - Mathias Svensson - Applied some bug fixes from paches recived from Gilles Vollant
> + Oct-2009 - Mathias Svensson - Applied some bug fixes from paches received from Gilles Vollant
"...from patches..."
> Oct-2009 - Mathias Svensson - Applied support to unzip files with compression mathod BZIP2 (bzip2 lib is required)
"... with compression method..."
> @@ -380,8 +380,8 @@ local int strcmpcasenosensitive_internal (const char* fileName1, const char* fil
>
> /*
> Compare two filename (fileName1,fileName2).
> - If iCaseSenisivity = 1, comparision is case sensitivity (like strcmp)
> - If iCaseSenisivity = 2, comparision is not case sensitivity (like strcmpi
> + If iCaseSenisivity = 1, comparison is case sensitivity (like strcmp)
> + If iCaseSenisivity = 2, comparison is not case sensitivity (like strcmpi
"...case sensitive..."?
> or strcasecmp)
> If iCaseSenisivity = 0, case sensitivity is defaut of your operating system
> (like 1 on Unix, 2 on Windows)
> diff --git a/zlib/contrib/minizip/unzip.h b/zlib/contrib/minizip/unzip.h
> index 2104e39..9e7378d 100644
> --- a/zlib/contrib/minizip/unzip.h
> +++ b/zlib/contrib/minizip/unzip.h
> @@ -155,8 +155,8 @@ extern int ZEXPORT unzStringFileNameCompare OF ((const char* fileName1,
> int iCaseSensitivity));
> /*
> Compare two filename (fileName1,fileName2).
> - If iCaseSenisivity = 1, comparision is case sensitivity (like strcmp)
> - If iCaseSenisivity = 2, comparision is not case sensitivity (like strcmpi
> + If iCaseSenisivity = 1, comparison is case sensitivity (like strcmp)
> + If iCaseSenisivity = 2, comparison is not case sensitivity (like strcmpi
Same here.
> or strcasecmp)
> If iCaseSenisivity = 0, case sensitivity is defaut of your operating system
> (like 1 on Unix, 2 on Windows)
> diff --git a/zlib/contrib/minizip/zip.c b/zlib/contrib/minizip/zip.c
> index ea54853..976aad0 100644
> --- a/zlib/contrib/minizip/zip.c
> +++ b/zlib/contrib/minizip/zip.c
> @@ -15,7 +15,7 @@
> Oct-2009 - Mathias Svensson - Did some code cleanup and refactoring to get better overview of some functions.
> Oct-2009 - Mathias Svensson - Added zipRemoveExtraInfoBlock to strip extra field data from its ZIP64 data
> It is used when recreting zip archive with RAW when deleting items from a zip.
"... when recreating..."
> - ZIP64 data is automaticly added to items that needs it, and existing ZIP64 data need to be removed.
> + ZIP64 data is automatically added to items that needs it, and existing ZIP64 data need to be removed.
> Oct-2009 - Mathias Svensson - Added support for BZIP2 as compression mode (bzip2 lib is required)
"... to items that need it..."
"... and existing ZIP64 data needs to..."
Otherwise looks good. Quite a few typos, thanks!
next prev parent reply other threads:[~2016-11-25 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 19:45 [PATCH 0/3] Fix spelling mistakes in comments - ZLIB Ambrogino Modigliani
2016-11-25 19:45 ` [PATCH 3/3] Fix spelling in comments in Assembler files (zlib) Ambrogino Modigliani
2016-11-25 19:45 ` [PATCH 2/3] Fix spelling in comments in Ada source " Ambrogino Modigliani
2016-11-25 19:45 ` [PATCH 1/3] Fix spelling in comments in C " Ambrogino Modigliani
2016-11-25 21:01 ` Luis Machado [this message]
2016-11-25 20:01 ` [PATCH 0/3] Fix spelling mistakes in comments - ZLIB Pedro Alves
2016-11-25 20:40 ` Ambrogino Modigliani
2016-11-25 21:16 ` Joseph Myers
2016-11-25 21:35 ` Mike Frysinger
2016-11-25 20:42 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b486af6-76ee-2033-08e1-16a106d5e6ef@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=ambrogino.modigliani@gmail.com \
--cc=ambrogino.modigliani@mail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).