From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 319F43857835 for ; Fri, 6 Oct 2023 22:05:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 319F43857835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4S2Mtv4ql7z3SrM; Fri, 6 Oct 2023 22:05:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2Mtv25RMz4GkH; Fri, 6 Oct 2023 22:05:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696629943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9G2l5+YkAts/+RV/cmmvLOfutPxzufxUL0UqwX4e4vs=; b=AIa0IxjVFZNnM+hrMK2eUQLhu8/DXu1qe3nS2JjKv9ZLqDFjC6InZ72VMOouU5UJdThTb2 ii5mawNJoBpAzG7DLXJL0Wu858CtRjBo/C9KvdttWwTFbP/YWiXG7BfoXi7McxoQDfcrJY 6cyRk4Kc4FAcMsbFinIrrTGUG4oMQcQ0gNbQtmIFNCCMH9rtQSkI+cblLfeeqcsRIi9Otq gk7mpC8IsET4yuMvW/aHxgMMgtEC53dZziLZYLSUgJyxLimg5Mgt0nEsb7N3ee0UcqTSIX BaY6vJvZupgfpMRs67i1QU9gaNvEepY80s9XY0T5/CjxvxOccRnpOf9+SsHMRA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696629943; a=rsa-sha256; cv=none; b=ka4FLGuDaGP+3uqWbfV1qOwoS9xh0hmgyCxf7x0ea9tLPgvbgkAlm9SIn/fVd9Yy4i8gR7 rdCdJHkbfpRKSMyLSkiuX/J4hEo40+iPXgUkwgGQDhB+0S92xthr/M9kTaZXaeqnbaXjcB YAC2uZ1xWyZezP8lrI0ow6cdOj+NBn4RqtkFnr1lZn6VfHeoJnJnDIqgkzIdVkfnCv6Plj EQuU7lfviN++OtOz9HPsOEROITztRB22PfBg2guGnObTBVzoDvi6UYTwRh3HISd9yoeoE9 sF8v6XQg+JV7F3mG9zv9TpqDnQEltYAJuxDzxZ2lad80JCoRkvLmubt3DCtKYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696629943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9G2l5+YkAts/+RV/cmmvLOfutPxzufxUL0UqwX4e4vs=; b=IUyjj4hwsP93louZ1VRzcvJKtFwanULhFKTYeiEJ2ifBHcILNatpcNMWWk+gEToCbzkjro Hw/LEdOCOLkyzpl7XhW517zz3RXfr2v768CyUCZk28Co+POfZfOdO09QvksyvjrdXESTdU DFcy634CUnJoNQSGXlNeqT7eCHRS1qqPRKyBbJSc4kcc9I0fwYgoM+mPxLYcyYR00uARi2 xmu7woRdj/Ngv0Vq+1l/Xplrx2E99DhUOAFgVDENhW8M5EJrMy/i9JtjMGuCat3NpjCcFr A4gAaIpdL0vGNfatJU096OmXPMo4prHK4419YiXrZA8o8KR4ErcGHfX/8eO79Q== Received: from [IPV6:2601:648:8683:39a0:355d:333f:e690:4130] (unknown [IPv6:2601:648:8683:39a0:355d:333f:e690:4130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4S2Mtt66dqz1SGb; Fri, 6 Oct 2023 22:05:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <0b4cad10-dc87-6645-e397-18f26c9f04dc@FreeBSD.org> Date: Fri, 6 Oct 2023 15:05:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 0/5] Various inferior / arch cleanups Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230929182541.138320-1-simon.marchi@efficios.com> From: John Baldwin In-Reply-To: <20230929182541.138320-1-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/29/23 2:24 PM, Simon Marchi via Gdb-patches wrote: > I'm in the middle of a bigger change, moving things around, and > extracted these patches which make sense on their own, I think. No > changes in behavior expected. > > Simon Marchi (5): > gdb: add inferior::{arch, set_arch} > gdb: add inferior parameter to architecture_changed observable > gdb: move set_target_gdbarch to inferior::set_arch > gdb: remove target_gdbarch > gdb: scope down registers_changed call in inferior::set_arch > > gdb/aarch64-linux-nat.c | 14 ++-- > gdb/ada-lang.c | 7 +- > gdb/ada-tasks.c | 9 +-- > gdb/aix-thread.c | 5 +- > gdb/amd-dbgapi-target.c | 4 +- > gdb/amd64-linux-nat.c | 2 +- > gdb/arc-tdep.c | 5 +- > gdb/arch-utils.c | 31 +++------ > gdb/arm-fbsd-tdep.c | 2 +- > gdb/arm-tdep.c | 15 ++-- > gdb/auxv.c | 21 +++--- > gdb/break-catch-syscall.c | 2 +- > gdb/breakpoint.c | 16 ++--- > gdb/bsd-uthread.c | 15 ++-- > gdb/btrace.c | 3 +- > gdb/cli/cli-dump.c | 5 +- > gdb/compile/compile-c-symbols.c | 12 ++-- > gdb/compile/compile-cplus-symbols.c | 12 ++-- > gdb/compile/compile-object-load.c | 52 +++++++------- > gdb/corefile.c | 3 +- > gdb/corelow.c | 2 +- > gdb/cp-namespace.c | 3 +- > gdb/cp-support.c | 3 +- > gdb/d-namespace.c | 3 +- > gdb/darwin-nat-info.c | 12 ++-- > gdb/dcache.c | 6 +- > gdb/disasm.c | 11 +-- > gdb/elfread.c | 4 +- > gdb/fbsd-nat.c | 2 +- > gdb/filesystem.c | 3 +- > gdb/frame-unwind.c | 3 +- > gdb/gcore-elf.c | 2 +- > gdb/gcore.c | 49 ++++++------- > gdb/gdbarch.h | 24 +------ > gdb/gnu-nat.c | 6 +- > gdb/i386-darwin-nat.c | 8 +-- > gdb/i386-tdep.c | 6 +- > gdb/ia64-vms-tdep.c | 2 +- > gdb/infcmd.c | 8 +-- > gdb/inferior.c | 19 ++++- > gdb/inferior.h | 33 +++++---- > gdb/infrun.c | 19 ++--- > gdb/jit.c | 5 +- > gdb/linux-nat.c | 10 +-- > gdb/linux-tdep.c | 6 +- > gdb/memattr.c | 9 +-- > gdb/mep-tdep.c | 4 +- > gdb/mi/mi-interp.c | 8 +-- > gdb/mi/mi-main.c | 2 +- > gdb/microblaze-tdep.c | 2 +- > gdb/mips-linux-nat.c | 6 +- > gdb/mips-linux-tdep.c | 5 +- > gdb/mips-tdep.c | 15 ++-- > gdb/moxie-tdep.c | 4 +- > gdb/msp430-tdep.c | 3 +- > gdb/netbsd-nat.c | 2 +- > gdb/nto-procfs.c | 5 +- > gdb/nto-tdep.c | 29 ++++---- > gdb/observable.h | 5 +- > gdb/ppc-linux-nat.c | 2 +- > gdb/ppc-linux-tdep.c | 2 +- > gdb/printcmd.c | 66 +++++++++--------- > gdb/proc-service.c | 2 +- > gdb/process-stratum-target.c | 2 +- > gdb/process-stratum-target.h | 3 +- > gdb/procfs.c | 24 ++++--- > gdb/progspace.c | 10 +-- > gdb/python/py-finishbreakpoint.c | 2 +- > gdb/python/py-inferior.c | 16 ++--- > gdb/python/py-objfile.c | 5 +- > gdb/python/py-progspace.c | 5 +- > gdb/python/py-record-btrace.c | 2 +- > gdb/python/py-unwind.c | 2 +- > gdb/python/python.c | 4 +- > gdb/ravenscar-thread.c | 7 +- > gdb/record-btrace.c | 2 +- > gdb/record-full.c | 19 +++-- > gdb/regcache-dump.c | 6 +- > gdb/regcache.c | 8 +-- > gdb/remote-sim.c | 2 +- > gdb/remote.c | 73 +++++++++++--------- > gdb/rl78-tdep.c | 6 +- > gdb/rs6000-aix-nat.c | 5 +- > gdb/rs6000-tdep.c | 2 +- > gdb/rust-parse.c | 5 +- > gdb/rx-tdep.c | 5 +- > gdb/s390-linux-nat.c | 2 +- > gdb/scoped-mock-context.h | 2 +- > gdb/sol-thread.c | 13 ++-- > gdb/solib-darwin.c | 30 ++++---- > gdb/solib-dsbt.c | 26 +++---- > gdb/solib-frv.c | 19 ++--- > gdb/solib-rocm.c | 2 +- > gdb/solib-svr4.c | 88 ++++++++++++++---------- > gdb/solib.c | 37 +++++----- > gdb/sparc64-tdep.c | 14 ++-- > gdb/symfile-mem.c | 4 +- > gdb/symfile.c | 11 +-- > gdb/symtab.c | 6 +- > gdb/target-descriptions.c | 4 +- > gdb/target.c | 33 +++++---- > gdb/target.h | 2 +- > gdb/tracefile-tfile.c | 25 ++++--- > gdb/tracefile.c | 3 +- > gdb/tracepoint.c | 31 ++++----- > gdb/tui/tui-disasm.c | 2 +- > gdb/unittests/frame_info_ptr-selftests.c | 2 +- > gdb/value.c | 4 +- > gdb/windows-nat.c | 2 +- > gdb/windows-tdep.c | 10 +-- > gdb/z80-tdep.c | 2 +- > 111 files changed, 667 insertions(+), 577 deletions(-) > > > base-commit: 4ebfd53de03599b73838ee339e47652ac26c37c0 I only skimmed these, but these seem ok to me in principle. -- John Baldwin