From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id A82F83858D1E for ; Wed, 4 Jan 2023 12:27:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A82F83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8A322220CB; Wed, 4 Jan 2023 12:27:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1672835270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZRMvvW3B64oG/5KRp0tqEpD/VEI3ir9Vm3uJJVv8W4=; b=XVRmjJdtkTzqNRtcHZu27o/lriweuIQYNpqnuuAXPudVp4WQthJbQ8HIXiTYMCzGbJtAnh iLBCbs/3RGwfH8eCTdEPMclVv9Xe8mUYBUs5gsGsmyhDuTR8wDpUonHdK3U60OLQyJgumh +HR8yKrcV1fd3QS+qwh2lEbVzlg8zJk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1672835270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PZRMvvW3B64oG/5KRp0tqEpD/VEI3ir9Vm3uJJVv8W4=; b=uHEKCcgIpKawRsVl/2BpEnr1V4kVArMfqyJTzlhK3doJXQTGC1oG0qlS0ORNUy/qhpVMsC aSRfPtdiGnp7DZBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 74EFE133D1; Wed, 4 Jan 2023 12:27:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5dhhG8ZwtWOMEwAAMHmgww (envelope-from ); Wed, 04 Jan 2023 12:27:50 +0000 Message-ID: <0b6635ea-ee55-1edd-6f4b-149a3ab200f5@suse.de> Date: Wed, 4 Jan 2023 13:27:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] Initial implementation of Debugger Adapter Protocol Content-Language: en-US To: Tom Tromey Cc: Tom Tromey via Gdb-patches References: <20220901163059.3678708-1-tromey@adacore.com> <87bkrk8j21.fsf@tromey.com> <877d1duivp.fsf@tromey.com> <87k024khch.fsf@tromey.com> <5cd9edba-b1b2-060e-d8d2-98ff6d28a5e7@suse.de> <87tu17iu2j.fsf@tromey.com> <7f2d41d6-ba52-a7da-4144-a252aabd10ea@suse.de> From: Tom de Vries In-Reply-To: <7f2d41d6-ba52-a7da-4144-a252aabd10ea@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/4/23 12:59, Tom de Vries via Gdb-patches wrote: > On 1/3/23 15:14, Tom Tromey wrote: >> Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c: In member >> Tom> function ‘virtual void dap_interp::init(bool)’: >> Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: error: >> Tom> ‘PyObject_CallNoArgs’ was not declared in this scope >> Tom>    gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); >> Tom>                            ^~~~~~~~~~~~~~~~~~~ >> Tom> /home/vries/gdb_versions/devel/src/gdb/python/py-dap.c:83:27: note: >> Tom> suggested alternative: ‘_PyObject_CallNoArg’ >> Tom>    gdbpy_ref<> result_obj (PyObject_CallNoArgs (func.get ())); >> Tom>                            ^~~~~~~~~~~~~~~~~~~ >> Tom>                            _PyObject_CallNoArg >> Tom> ... >> >> Sorry about that.  I'm going to apply the appended, which should fix the >> problem. > > That fixed the build problem, thanks for that. > > Now I'm running into an error in the testsuite: > ... > ERROR: eof reading json header >     while executing > "error "eof reading json header"" >     invoked from within > "expect { > -i exp19 -timeout 10 >         -re "^Content-Length: (\[0-9\]+)\r\n" { >             set length $expect_out(1,string) >             exp_continue >         } >         -re "^(\[^\r\n\]+)..." >     ("uplevel" body line 1) >     invoked from within > "uplevel $body" NONE eof reading json header > UNRESOLVED: gdb.dap/basic-dap.exp: startup - initialize > ... Hmm, that seems to be because: ... (gdb) #5 0x0000000000a59a7c in gdbpy_handle_exception () at /home/vries/gdb_versions/devel/src/gdb/python/py-utils.c:396 396 error (_("Error occurred in Python: %s"), msg.get ()); (gdb) p msg.get () $1 = 0x2b91d10 "module 'queue' has no attribute 'SimpleQueue'" ... That's new in python 3.7, and I have: ... $ ldd ./gdb | grep python libpython3.6m.so.1.0 => /usr/lib64/libpython3.6m.so.1.0 (0x00007f93ed624000) ... Thanks, - Tom