From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 00/10] Fix two name-related bugs in DWARF reader
Date: Fri, 24 Apr 2020 16:18:43 +0200 [thread overview]
Message-ID: <0b722738-d3df-9f18-e90e-57f3a72151b2@suse.de> (raw)
In-Reply-To: <20200325200715.12947-1-tom@tromey.com>
On 25-03-2020 21:07, Tom Tromey wrote:
> I started this series by trying to fix PR rust/25025. This showed
> that the Rust compiler sometimes emits two mangled forms that demangle
> to the same thing.
>
> In the end I could maybe have fixed this in a direct way (see patch #9
> for the details), but while debugging I went on a detour into the
> physname code and came up with this series.
>
> This changes the DWARF reader to avoid demangling when constructing
> partial symbols. This obsoletes my previous patch to do the same
> thing; I think this approach is cleaner.
>
> It also attempts to fix the longstanding physname bug, PR 12707.
> After this series, the demangled form is now stored on the symbol
> again.
>
> Regression tested by the buildbot.
As extra data point, I've build and tested this series, and got
unexpected failures reduced from 8 to 1:
...
=== gdb Summary ===
# of expected passes 78972
# of unexpected failures 1
# of expected failures 135
# of known failures 72
# of untested testcases 24
# of unsupported tests 77
...
Thanks,
- Tom
next prev parent reply other threads:[~2020-04-24 14:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 20:07 Tom Tromey
2020-03-25 20:07 ` [PATCH 01/10] Convert symbol_set_demangled_name to a method Tom Tromey
2020-03-25 20:07 ` [PATCH 02/10] Move the rust "{" hack Tom Tromey
2020-03-25 20:07 ` [PATCH 03/10] Fix two latent Rust bugs Tom Tromey
2020-03-25 20:07 ` [PATCH 04/10] Add attribute::value_as_string method Tom Tromey
2020-03-25 20:07 ` [PATCH 05/10] Introduce new add_psymbol_to_list overload Tom Tromey
2020-03-25 20:07 ` [PATCH 06/10] Use the " Tom Tromey
2020-03-25 20:07 ` [PATCH 07/10] Don't call compute_and_set_names for partial symbols Tom Tromey
2020-03-25 20:07 ` [PATCH 08/10] Use the linkage name if it exists Tom Tromey
2020-04-24 16:06 ` Tom de Vries
2020-04-24 18:09 ` Tom de Vries
2020-04-24 20:50 ` Tom Tromey
2020-04-24 21:27 ` [committed][gdb/testsuite] Fix language in dw2-bad-mips-linkage-name.exp Tom de Vries
2020-04-24 21:34 ` Tom Tromey
2020-03-25 20:07 ` [PATCH 09/10] Fix Rust test cases Tom Tromey
2020-03-25 20:07 ` [PATCH 10/10] Remove symbol_get_demangled_name Tom Tromey
2020-03-25 22:48 ` [PATCH 00/10] Fix two name-related bugs in DWARF reader Christian Biesinger
2020-03-25 23:50 ` Tom Tromey
2020-04-24 14:18 ` Tom de Vries [this message]
2020-04-24 14:45 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b722738-d3df-9f18-e90e-57f3a72151b2@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).