From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 2519E3850435
 for <gdb-patches@sourceware.org>; Thu, 30 Jul 2020 17:03:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2519E3850435
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id B225E1E792;
 Thu, 30 Jul 2020 13:03:48 -0400 (EDT)
Subject: Re: [PATCH 4/4] gdb: change regcache list to be a map
To: Pedro Alves <pedro@palves.net>, Simon Marchi <simon.marchi@efficios.com>, 
 gdb-patches@sourceware.org
Cc: Laurent <Laurent.Morichetti@amd.com>
References: <20200720204101.2849535-1-simon.marchi@efficios.com>
 <20200720204101.2849535-5-simon.marchi@efficios.com>
 <5b521483-2f09-3424-943d-40f83b3080af@palves.net>
 <82d8b01a-2b37-0b79-f657-1081375270ee@simark.ca>
From: Simon Marchi <simark@simark.ca>
Message-ID: <0b8d1bd2-156f-626e-a6b8-813d69cc1340@simark.ca>
Date: Thu, 30 Jul 2020 13:03:42 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <82d8b01a-2b37-0b79-f657-1081375270ee@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Jul 2020 17:03:50 -0000

On 2020-07-30 12:58 p.m., Simon Marchi wrote:
> It's down to:
> 
>        for (auto it = regcaches.begin (); it != regcaches.end ();)
> 	 {
> 	   if (it->second->target () == target)
> 	     it = regcaches.erase (it);
> 	   else
> 	     it++;
> 	 }

Ah, I see that you've provided me a patch for that too (I thought you only
did the multi-level map thing).  Your code is:

        for (auto it = regcaches.begin (); it != regcaches.end ();)
          {
            if (it->second->target () == target)
              {
                delete it->second;
                it = regcaches.erase (it);
              }
          }

I think you are missing an it++ in the else?  Otherwise, when the target doesn't
match, we'll get into an infinite loop I presume.

Simon